From: David Ahern <dsahern@kernel.org>
To: Alex Henrie <alexhenrie24@gmail.com>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, jbohac@suse.cz,
benoit.boissinot@ens-lyon.org, davem@davemloft.net,
hideaki.yoshifuji@miraclelinux.com
Subject: Re: [PATCH] ipv6/addrconf: clamp preferred_lft to the minimum instead of erroring
Date: Tue, 22 Aug 2023 20:45:12 -0700 [thread overview]
Message-ID: <1f980abd-498a-8de8-2c62-0882bc1d3369@kernel.org> (raw)
In-Reply-To: <CAMMLpeRR_JmFp3DnDJbYdjxnpfxLke-z5KW=EA8_H_xj3FzXvg@mail.gmail.com>
On 8/22/23 9:41 PM, Alex Henrie wrote:
> Hi Paolo, thanks for the review.
>
> On Tue, Aug 22, 2023 at 3:54 AM Paolo Abeni <pabeni@redhat.com> wrote:
>
>> It looks like you are fixing 2 separate bugs, so 2 separate patches
>> would be better.
>
> The two problems are closely related, and in the same function. But I
> will split the patch into two patches to your preference.
>
>> You should explicitly state the target tree (in this case 'net') into
>> the patch subj.
>
> Will fix in v2, thanks.
>
>> You should add a suitable fixes tag to each patch.
>
> That would be "Fixes: 76506a986dc31394fd1f2741db037d29c7e57843" and
> "Fixes: eac55bf97094f6b64116426864cf4666ef7587bc", correct?
See `git log` and search for Fixes to see examples. e.g.,
Fixes: eac55bf97094 ("IPv6: do not create temporary adresses with too
short preferred lifetime")
next prev parent reply other threads:[~2023-08-23 3:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 1:11 [PATCH] ipv6/addrconf: clamp preferred_lft to the minimum instead of erroring Alex Henrie
2023-08-22 9:54 ` Paolo Abeni
2023-08-23 3:41 ` Alex Henrie
2023-08-23 3:45 ` David Ahern [this message]
2023-08-23 8:36 ` Jiri Bohac
2023-08-23 11:00 ` Paolo Abeni
2023-08-29 5:44 ` [PATCH v2 0/5] net: ipv6/addrconf: ensure that temporary addresses' preferred lifetimes are in the valid range Alex Henrie
2023-08-29 5:44 ` [PATCH v2 1/5] net: ipv6/addrconf: avoid integer underflow in ipv6_create_tempaddr Alex Henrie
2023-09-01 4:41 ` [PATCH v3] " Alex Henrie
2023-09-01 13:53 ` David Ahern
2023-09-04 6:21 ` patchwork-bot+netdevbpf
2023-08-29 5:44 ` [PATCH v2 2/5] net: ipv6/addrconf: clamp preferred_lft to the maximum allowed Alex Henrie
2023-08-31 8:25 ` Paolo Abeni
2023-08-29 5:44 ` [PATCH v2 3/5] net: ipv6/addrconf: clamp preferred_lft to the minimum required Alex Henrie
2023-08-31 1:28 ` Jakub Kicinski
2023-08-31 5:40 ` Alex Henrie
2023-08-29 5:44 ` [PATCH v2 4/5] Documentation: networking: explain what happens if temp_valid_lft is too small Alex Henrie
2023-08-29 5:44 ` [PATCH v2 5/5] Documentation: networking: explain what happens if temp_prefered_lft is too small or too large Alex Henrie
2023-08-31 8:33 ` Paolo Abeni
2023-10-24 19:40 ` [PATCH resend 1/4] net: ipv6/addrconf: clamp preferred_lft to the maximum allowed Alex Henrie
2023-10-24 19:40 ` [PATCH resend 2/4] net: ipv6/addrconf: clamp preferred_lft to the minimum required Alex Henrie
2023-10-24 19:40 ` [PATCH resend 3/4] Documentation: networking: explain what happens if temp_valid_lft is too small Alex Henrie
2023-10-24 19:40 ` [PATCH resend 4/4] Documentation: networking: explain what happens if temp_prefered_lft is too small or too large Alex Henrie
2023-10-24 19:48 ` [PATCH resend 1/4] net: ipv6/addrconf: clamp preferred_lft to the maximum allowed Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f980abd-498a-8de8-2c62-0882bc1d3369@kernel.org \
--to=dsahern@kernel.org \
--cc=alexhenrie24@gmail.com \
--cc=benoit.boissinot@ens-lyon.org \
--cc=davem@davemloft.net \
--cc=hideaki.yoshifuji@miraclelinux.com \
--cc=jbohac@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).