From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [GIT]: Networking Date: Mon, 05 Jan 2009 20:15:30 -0800 (PST) Message-ID: <20090105.201530.195720489.davem@davemloft.net> References: <20090105.183106.252630446.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: torvalds@linux-foundation.org Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:32925 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754540AbZAFEP3 (ORCPT ); Mon, 5 Jan 2009 23:15:29 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Linus Torvalds Date: Mon, 5 Jan 2009 18:42:19 -0800 (PST) > On Mon, 5 Jan 2009, David Miller wrote: > > > > Jaswinder Singh (1): > > firmware: convert acenic driver to request_firmware() > > Grr. But the old acenic_firmware.h file is left around. Which explains > this: > > > 63 files changed, 11470 insertions(+), 1910 deletions(-) > > Ugh. That looks absolutely horrible. > > I pulled, but please take a look at your own diffstats and then ask > yourself if things really look like they should look. Because if you had > done that, you'd have noticed this. Sorry, I know how this happened even. As an aside, is there a way to make git-am and other stuff using the git patch applying engine to take patches liberally like 'patch' would? The default is extremely strict, which makes me check things out by hand. That's good, but as I add the change by hand after verifying it's sanity I often make mistakes that result in things like the above missed delete, so if I could ask git to be non-strict it would help me out a lot. This doesn't excuse me from looking for bogons at my diffstats of course :)