From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>
Cc: david.choi@micrel.com, torvalds@linux-foundation.org,
akpm@linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: tip: origin tree boot crash (in the new micrel phy driver)
Date: Thu, 6 May 2010 12:44:39 +0200 [thread overview]
Message-ID: <20100506104439.GA29100@elte.hu> (raw)
In-Reply-To: <20100506.031435.235688827.davem@davemloft.net>
* David Miller <davem@davemloft.net> wrote:
> From: David Miller <davem@davemloft.net>
> Date: Thu, 06 May 2010 03:10:40 -0700 (PDT)
>
> > From: Ingo Molnar <mingo@elte.hu>
> > Date: Thu, 6 May 2010 11:59:40 +0200
> >
> >> I bisected it back to the following commit:
> >>
> >> d05070091849015f8c5b7d55cd75b86ebb61b3ec is the first bad commit
> >> commit d05070091849015f8c5b7d55cd75b86ebb61b3ec
> >> Author: David J. Choi <david.choi@micrel.com>
> >> Date: Thu Apr 29 06:12:41 2010 +0000
> >>
> >> drivers/net/phy: micrel phy driver
> ...
> >> Disabling the driver fixes the crash.
> >
> > David please fix this crash, thanks.
>
> Nevermind, Ingo please test this fix:
>
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 0cd80e4..e67691d 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -32,6 +32,7 @@ static int kszphy_config_init(struct phy_device *phydev)
>
> static struct phy_driver ks8001_driver = {
> .phy_id = PHY_ID_KS8001,
> + .name = "Micrel KS8001",
> .phy_id_mask = 0x00fffff0,
> .features = PHY_BASIC_FEATURES,
> .flags = PHY_POLL,
This fixes the crash, thanks Dave!
Tested-by: Ingo Molnar <mingo@elte.hu>
Ingo
prev parent reply other threads:[~2010-05-06 10:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 8:27 [GIT]: Networking David Miller
2010-05-06 9:59 ` tip: origin tree boot crash (in the new micrel phy driver) Ingo Molnar
2010-05-06 10:10 ` David Miller
2010-05-06 10:14 ` David Miller
2010-05-06 10:44 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506104439.GA29100@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=david.choi@micrel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).