From: Sarah Sharp <sarah.a.sharp-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Tilman Schmidt <tilman-ZTO5kqT2PaM@public.gmane.org>
Cc: Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
Hansjoerg Lipp <hjlipp-S0/GAf8tV78@public.gmane.org>,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
gigaset307x-common-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ath9k-devel-xDcbHBWguxHbcTqmT+pZeQ@public.gmane.org,
libertas-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
users-poMEt7QlJxcwIE2E9O76wjtx2kNaKg5H@public.gmane.org
Subject: Re: [RFC 13/13] USB: Disable hub-initiated LPM for comms devices.
Date: Thu, 17 May 2012 10:31:50 -0700 [thread overview]
Message-ID: <20120517173150.GE4967@xanatos> (raw)
In-Reply-To: <4FB53054.9070309-ZTO5kqT2PaM@public.gmane.org>
On Thu, May 17, 2012 at 07:07:32PM +0200, Tilman Schmidt wrote:
> Am 16.05.2012 23:55, schrieb Sarah Sharp:
> > Set the disable_hub_initiated_lpm flag for for all USB communications
> > drivers. I know there aren't currently any USB 3.0 devices that
> > implement these class specifications, but we should be ready if they do.
>
> I follow the argument for class drivers. But this patch also
> modifies drivers for specific existing USB 2.0 only devices
> which are unlikely to ever grow USB 3.0 support, such as the
> Gigaset ISDN driver:
>
> > drivers/isdn/gigaset/bas-gigaset.c | 1 +
> > drivers/isdn/gigaset/usb-gigaset.c | 1 +
Is there a particular reason why you think that driver is unlikely to
ever get USB 3.0 support? I pretty much grabbed any USB driver that
looked like a communications driver without looking too closely at the
code.
> What is the interest of setting the disable_hub_initiated_lpm
> flag for these?
It's partially to lay the foundation for anyone who wants to make a USB
3.0 communications driver in the future. They're likely to start from
some USB 2.0 class driver, and copy a lot of code. If they notice that
flag is set in all the USB communications class drivers, they're likely
to set it as well.
I'm not quite sure where the best place to provide documentation on the
flag is. I've added the kernel doc comments to the structure, but maybe
it needs to be documented somewhere in Documentation/usb/?
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-05-17 17:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 21:54 [RFC 00/13] USB 3.0 Link Power Management (LPM) support Sarah Sharp
[not found] ` <cover.1337203535.git.sarah.a.sharp-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2012-05-16 21:55 ` [RFC 05/13] USB: Allow drivers to disable hub-initiated LPM Sarah Sharp
2012-05-16 21:55 ` [RFC 13/13] USB: Disable hub-initiated LPM for comms devices Sarah Sharp
[not found] ` <3c634afbbe15598cdcbf77bb9393d22ad4bfa373.1337203535.git.sarah.a.sharp-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2012-05-17 17:07 ` Tilman Schmidt
[not found] ` <4FB53054.9070309-ZTO5kqT2PaM@public.gmane.org>
2012-05-17 17:31 ` Sarah Sharp [this message]
2012-05-17 17:50 ` Andre Bella
2012-05-18 22:38 ` Tilman Schmidt
[not found] ` <4FB6CF71.7080307-ZTO5kqT2PaM@public.gmane.org>
2012-05-18 23:09 ` Sarah Sharp
2012-05-16 22:45 ` [RFC 05/13] USB: Allow drivers to disable hub-initiated LPM Sarah Sharp
2012-05-16 22:45 ` [RFC 13/13] USB: Disable hub-initiated LPM for comms devices Sarah Sharp
2012-05-16 23:20 ` Greg Kroah-Hartman
[not found] ` <20120516232019.GA960-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2012-05-17 4:52 ` Sarah Sharp
2012-05-17 14:49 ` Greg Kroah-Hartman
2012-05-17 16:29 ` Sarah Sharp
2012-05-17 16:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120517173150.GE4967@xanatos \
--to=sarah.a.sharp-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=ath9k-devel-xDcbHBWguxHbcTqmT+pZeQ@public.gmane.org \
--cc=gigaset307x-common-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=hjlipp-S0/GAf8tV78@public.gmane.org \
--cc=libertas-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=tilman-ZTO5kqT2PaM@public.gmane.org \
--cc=users-poMEt7QlJxcwIE2E9O76wjtx2kNaKg5H@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).