From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] virtio-net: put virtio net header inline with data Date: Tue, 9 Jul 2013 08:18:24 +0300 Message-ID: <20130709051824.GA3234@redhat.com> References: <20130708101259.GA16074@redhat.com> <871u78eavc.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Cong Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Dave Jones , "David S. Miller" To: Rusty Russell Return-path: Content-Disposition: inline In-Reply-To: <871u78eavc.fsf@rustcorp.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Tue, Jul 09, 2013 at 11:46:23AM +0930, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > For small packets we can simplify xmit processing > > by linearizing buffers with the header: > > most packets seem to have enough head room > > we can use for this purpose. > > Since existing hypervisors require that header > > is the first s/g element, we need a feature bit > > for this. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > > > Note: this needs to be applied on top of patch > > defining VIRTIO_F_ANY_LAYOUT - bit to be > > selected by Rusty. > > > > The following patch should work for any definition of > > VIRTIO_F_ANY_LAYOUT - I used bit 31 for testing. > > Rusty, could you please pick a valid bit for VIRTIO_F_ANY_LAYOUT > > and squeeze this patch into 3.11? > > Sorry, it's too late. > > First, I've been a bit lax in sending patches via DaveM, and this is > definitely his territory (ie. more net than virtio). Let's do this: I'll send a patch series, you ack and we see what happens? > Secondly, it needs baking and testing time. > > Cheers, > Rusty. I did some testing on this. But proper testing just isn't happening out of tree. -- MST