netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: pshelar@nicira.com
Cc: netdev@vger.kernel.org, stephen@networkplumber.org
Subject: Re: [PATCH net-next] vxlan: Fix kernel crash on rmmod.
Date: Wed, 10 Jul 2013 17:52:33 -0700 (PDT)	[thread overview]
Message-ID: <20130710.175233.571212108853436298.davem@davemloft.net> (raw)
In-Reply-To: <1373409548-26064-1-git-send-email-pshelar@nicira.com>

From: Pravin B Shelar <pshelar@nicira.com>
Date: Tue,  9 Jul 2013 15:39:08 -0700

> Following commit fixes the crash by fixing module exit path.
 ...
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>

This commit message is way too terse.

Please explain exactly why it's important to unregister the pernet
device after unregistering the rtnl link ops and destroying vxlan_wq.

Stephen explicitly put the operations in this order in commit
758c57d16adcbec3c03e85f0c9a5b4ca31f6c507 ("vxlan: fix crash from work
pending on module removal")

      reply	other threads:[~2013-07-11  0:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-09 22:39 [PATCH net-next] vxlan: Fix kernel crash on rmmod Pravin B Shelar
2013-07-11  0:52 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130710.175233.571212108853436298.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@nicira.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).