From: Dominique Martinet <dominique.martinet@cea.fr>
To: David Miller <davem@davemloft.net>
Cc: pebolle@tiscali.nl, lucho@ionkov.net, ericvh@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
andi@etezian.org, v9fs-developer@lists.sourceforge.net,
rminnich@sandia.gov
Subject: Re: [V9fs-developer] [PATCH] net: trans_rdma: remove unused function
Date: Thu, 25 Jul 2013 08:48:02 +0200 [thread overview]
Message-ID: <20130725064802.GA12569@nautica> (raw)
In-Reply-To: <20130725061411.GA8579@nautica>
Hard morning, sorry for the double mail.
Dominique Martinet wrote on Thu, Jul 25, 2013 :
> Well, I do care - but I couldn't find where the trans->cancelled member
> function was supposed to be called anyway...
> So adding it to the struct and fixing the warning is well and fine, but
> if it's still never called in the end I don't see much point and there's
> nothing to test.
To be more precise, there's a single call to c->trans_mode->cancelled in
net/9p/client.c, in p9_client_flush, which is called on subfunction returning
-ERESTARTSYS... which never happens as far as I could see.
This will be useful once/if we start working on client recovery, though
- so the function in itself definitely does interest me, and I guess
that thinking about I would have preferred to have the hook added rather
than the function removed.
But there definitely is no hurry to add this cancelled function till
then.
Regards,
--
Dominique Martinet
next prev parent reply other threads:[~2013-07-25 6:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 12:59 [PATCH] net: trans_rdma: remove unused function Andi Shyti
2013-07-24 22:46 ` David Miller
2013-07-24 23:09 ` Paul Bolle
2013-07-24 23:45 ` David Miller
2013-07-25 6:14 ` [V9fs-developer] " Dominique Martinet
2013-07-25 6:48 ` Dominique Martinet [this message]
2013-07-25 8:27 ` Andi Shyti
2013-07-25 8:35 ` David Miller
[not found] ` <CAFkjPTm1FH24EfWMDrXTh7DmU8WAb0ji-jkUgkayqMzfWj9O0A@mail.gmail.com>
2013-07-25 19:05 ` Dominique Martinet
2013-07-26 7:01 ` Dominique Martinet
[not found] ` <CAFkjPTkr5JYf6qc=pjcG8rSoocFekU-cTw450SujTvpCp33cyw@mail.gmail.com>
2013-07-26 15:17 ` Dominique Martinet
2013-07-25 8:54 ` [PATCH] 9p: client: remove unused code and any reference to "cancelled" function Andi Shyti
2013-07-25 8:57 ` Andi Shyti
2013-07-30 22:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725064802.GA12569@nautica \
--to=dominique.martinet@cea.fr \
--cc=andi@etezian.org \
--cc=davem@davemloft.net \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=rminnich@sandia.gov \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).