From: David Miller <davem@davemloft.net>
To: cwang@twopensource.com
Cc: kkolasa@winsoft.pl, eric.dumazet@gmail.com,
netdev@vger.kernel.org, edumazet@gmail.com
Subject: Re: something is wrong in commit 971f10eca1 - tcp: better TCP_SKB_CB layout to reduce cache line misses
Date: Tue, 14 Oct 2014 15:03:00 -0400 (EDT) [thread overview]
Message-ID: <20141014.150300.536881166743492994.davem@davemloft.net> (raw)
In-Reply-To: <CAHA+R7N9rNUH4aytFG3YLt8nzpERqmf34FgaWbe5R7P0AaWuZw@mail.gmail.com>
From: Cong Wang <cwang@twopensource.com>
Date: Tue, 14 Oct 2014 11:59:25 -0700
> On Tue, Oct 14, 2014 at 6:25 AM, Krzysztof Kolasa <kkolasa@winsoft.pl> wrote:
>> W dniu 14.10.2014 o 02:09, Cong Wang pisze:
>>
>>> On Mon, Oct 13, 2014 at 4:59 PM, Cong Wang <cwang@twopensource.com> wrote:
>>>>
>>>> Probably not related with this bug, but with regarding to the
>>>> offending commit, what's the point of the memmove() in tcp_v4_rcv()
>>>> since ip_rcv() already clears IPCB()?
>>>
>>> Oh, ip options are actually saved in ip_rcv_finish()... Hmm, looks scary
>>> to play with variable-length array with memmove()....
>>>
>> On my other old laptop with 32bit kernel next and graphics card Intel 945GM
>> just after the revert commit working OK,
>> before, after login to gnome shell in some seconds decorations disappear
>>
>> 32 bit Ubuntu 12.04.5 LTS, gnome shell, kernel source next 14-10-2014
>>
>> Can anyone confirm this ?
>>
>
> Sorry, believe it or not, for me it is hard to find a 32bit machine even VM. :)
>
> Could the attached patch by any chance help? I noticed cookie_v4_check()
> still uses IPCB() instead of TCPCB() at TCP layer.
Eric, please review.
next prev parent reply other threads:[~2014-10-14 19:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 17:11 something is wrong in commit 971f10eca1 - tcp: better TCP_SKB_CB layout to reduce cache line misses Krzysztof Kolasa
2014-10-12 18:46 ` Eric Dumazet
2014-10-13 23:59 ` Cong Wang
2014-10-14 0:09 ` Cong Wang
2014-10-14 13:25 ` Krzysztof Kolasa
2014-10-14 18:59 ` Cong Wang
2014-10-14 19:03 ` David Miller [this message]
[not found] ` <CAFrEnehWNzmzZGV-ZGbZF=wJ1q0TjFtB1yG6Dp1yVrJmBj9B7Q@mail.gmail.com>
2014-10-14 20:47 ` David Miller
2014-10-14 21:03 ` Eric Dumazet
2014-10-14 21:15 ` David Miller
2014-10-14 21:24 ` Cong Wang
2014-10-14 21:43 ` Eric Dumazet
2014-10-15 10:35 ` Krzysztof Kolasa
2014-10-15 11:27 ` Eric Dumazet
2014-10-15 11:40 ` Krzysztof Kolasa
2014-10-15 15:32 ` Eric Dumazet
2014-10-15 20:20 ` Krzysztof Kolasa
2014-10-15 20:36 ` Cong Wang
2014-10-15 20:42 ` Krzysztof Kolasa
2014-10-15 21:22 ` Cong Wang
2014-10-15 21:25 ` Cong Wang
2014-10-15 21:39 ` Eric Dumazet
2014-10-15 21:42 ` Eric Dumazet
2014-10-17 19:29 ` David Miller
2014-10-17 19:48 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014.150300.536881166743492994.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cwang@twopensource.com \
--cc=edumazet@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=kkolasa@winsoft.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).