From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: andrew@lunn.ch, sfr@canb.auug.org.au, netdev@vger.kernel.org,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
f.fainelli@gmail.com
Subject: Re: linux-next: Signed-off-by missing for commits in the net-next tree
Date: Sun, 09 Dec 2018 16:28:05 -0800 (PST) [thread overview]
Message-ID: <20181209.162805.1102172618676272423.davem@davemloft.net> (raw)
In-Reply-To: <011f5be3-4bc1-2e64-0ddf-b43b8dbc4dcd@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sun, 9 Dec 2018 22:33:10 +0100
> On 09.12.2018 22:11, Andrew Lunn wrote:
>> On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Commits
>>>
>>> dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data")
>>> 04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask")
>>>
>>> are missing a Signed-off-by from their author.
>>
>> Hi David.
>>
>> Any idea what happened here? The version in my git repo has SOB.
>>
>> https://patchwork.ozlabs.org/patch/1009811/ also has my SOB.
>>
> Instead of
> v2
> --
> int -> u32 in platform data structure
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
>
> shouldn't it be
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> v2
> - int -> u32 in platform data structure
No, I want the changelog to actually appear in the commit message.
I'm kinda tired of saying this.
Keep changelog information in the commit message, everyone.
The problem here is the '--' delimiter, Andrew should have either
used nothing or something else.
next prev parent reply other threads:[~2018-12-10 0:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 21:00 linux-next: Signed-off-by missing for commits in the net-next tree Stephen Rothwell
2018-12-09 21:11 ` Andrew Lunn
2018-12-09 21:33 ` Heiner Kallweit
2018-12-09 21:49 ` Andrew Lunn
2018-12-09 23:27 ` Sabrina Dubroca
2018-12-10 0:31 ` David Miller
2018-12-10 0:48 ` Stephen Rothwell
2018-12-10 0:54 ` David Miller
2018-12-10 2:05 ` Stephen Rothwell
2018-12-10 0:28 ` David Miller [this message]
2018-12-10 13:35 ` Andrew Lunn
2018-12-10 13:55 ` Sabrina Dubroca
2018-12-10 0:27 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2022-03-06 20:22 Stephen Rothwell
2022-03-07 23:02 ` Jakub Kicinski
2022-03-07 23:19 ` Stephen Rothwell
2022-03-07 23:24 ` Jakub Kicinski
2022-01-26 20:57 Stephen Rothwell
2022-01-26 22:50 ` Russell King (Oracle)
2021-08-21 3:08 Stephen Rothwell
2021-08-21 6:37 ` Sven Eckelmann
2020-03-10 10:01 Stephen Rothwell
2020-03-10 23:57 ` Saeed Mahameed
2020-04-13 0:05 ` Stephen Rothwell
2020-04-16 1:58 ` Saeed Mahameed
2019-11-25 7:28 Stephen Rothwell
2019-11-25 7:35 ` Daniel Borkmann
2019-08-15 21:53 Stephen Rothwell
2019-08-15 22:06 ` Gerd Rausch
2019-08-16 9:15 ` Andy Grover
2019-08-16 12:45 ` Chris Mason
2019-08-16 14:10 ` Gerd Rausch
2019-08-16 14:31 ` Stephen Rothwell
2018-10-19 7:30 Stephen Rothwell
2018-04-02 2:30 Stephen Rothwell
2018-04-02 5:38 ` Johan Hedberg
2018-04-02 6:50 ` Stephen Rothwell
2018-03-02 4:52 Stephen Rothwell
2017-12-18 20:41 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181209.162805.1102172618676272423.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).