From: Andrew Lunn <andrew@lunn.ch>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: Possible bug into DSA2 code.
Date: Sat, 9 Feb 2019 20:34:09 +0100 [thread overview]
Message-ID: <20190209193409.GI30856@lunn.ch> (raw)
In-Reply-To: <528f797d-445b-a314-d8ef-db15a3b6a8ce@enneenne.com>
> So we I see two possible solutions:
>
> 1) having both ds->slave_mii_bus and ds->ops->phy_read already defined is an
> error, then it must be signaled to the calling code, or
I don't think we can do that. mv88e6xxx optionally instantiates the
MDIO busses, depending on what is in device tree. If there is no mdio
property, we need the DSA core to create an MDIO bus.
Looking at the driver, ds->slave_mii_bus is assigned in
mv88e6xxx_setup().
We have talked about adding a teardown() to the ops structure. This
seems like another argument we should do it. The mv88e6xxx_teardown()
can set ds->slave_mii_bus back to NULL, undoing what it did in the
setup code.
Andrew
next prev parent reply other threads:[~2019-02-09 19:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a121e6b5-03cd-da9e-42e8-41c68e12babe@enneenne.com>
2019-02-09 8:24 ` Possible bug into DSA2 code Rodolfo Giometti
2019-02-09 19:34 ` Andrew Lunn [this message]
2019-02-10 11:45 ` Rodolfo Giometti
2019-02-11 17:28 ` Florian Fainelli
2019-02-11 17:51 ` Rodolfo Giometti
2019-02-11 18:01 ` Florian Fainelli
2019-02-11 19:13 ` Florian Fainelli
2019-02-18 10:38 ` Rodolfo Giometti
2019-02-19 0:03 ` Andrew Lunn
2019-02-20 7:54 ` Rodolfo Giometti
2019-02-20 15:02 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190209193409.GI30856@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=giometti@enneenne.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).