From: Stephen Hemminger <stephen@networkplumber.org>
To: Aya Levin <ayal@mellanox.com>
Cc: David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Jiri Pirko <jiri@mellanox.com>,
Moshe Shemesh <moshe@mellanox.com>,
Eran Ben Elisha <eranbe@mellanox.com>,
Tal Alon <talal@mellanox.com>, Ariel Almog <ariela@mellanox.com>
Subject: Re: [PATCH for-next 4/4] devlink: add health command support
Date: Sun, 10 Feb 2019 12:42:22 -0800 [thread overview]
Message-ID: <20190210124222.59c5d0aa@hermes.lan> (raw)
In-Reply-To: <1549823329-10377-5-git-send-email-ayal@mellanox.com>
On Sun, 10 Feb 2019 20:28:49 +0200
Aya Levin <ayal@mellanox.com> wrote:
> +
> +static void cmd_health_help(void)
> +{
> + pr_err("Usage: devlink health show [ dev DEV reporter REPORTER_NAME ]\n");
> + pr_err("Usage: devlink health recover DEV reporter REPORTER_NAME\n");
> + pr_err("Usage: devlink health diagnose DEV reporter REPORTER_NAME\n");
> + pr_err("Usage: devlink health dump show DEV reporter REPORTER_NAME\n");
> + pr_err("Usage: devlink health dump clear DEV reporter REPORTER_NAME\n");
> + pr_err("Usage: devlink health set DEV reporter REPORTER_NAME NAME VALUE\n");
> +}
> +
Minor nit:
I prefer that all code and outputs in iproute2 look the same for ease
of maintenance and constituency of user experience.
Why does devlink not use:
static void cmd_health_help(void)
{
fprintf(stderr, "Usage: devlink health show [ dev DEV reporter REPORTER_NAME ]\n");
fprintf(stderr, " devlink health recover DEV reporter REPORTER_NAME\n");
fprintf(stderr, " devlink health diagnose DEV reporter REPORTER_NAME\n");
...
Or
fprintf(stderr, "Usage: devlink health show [ dev DEV reporter REPORTER_NAME ]\n"
" devlink health recover DEV reporter REPORTER_NAME\n"
" devlink health diagnose DEV reporter REPORTER_NAME\n");
next prev parent reply other threads:[~2019-02-10 20:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 9:36 [PATCH v4 net-next 00/11] Devlink health reporting and recovery system Eran Ben Elisha
2019-02-07 9:36 ` [PATCH v4 net-next 01/11] devlink: Add devlink formatted message (fmsg) API Eran Ben Elisha
2019-02-07 9:36 ` [PATCH v4 net-next 02/11] devlink: Add health reporter create/destroy functionality Eran Ben Elisha
2019-02-07 9:36 ` [PATCH v4 net-next 03/11] devlink: Add health report functionality Eran Ben Elisha
2019-02-07 9:38 ` Jiri Pirko
2019-02-07 9:36 ` [PATCH v4 net-next 04/11] devlink: Add health get command Eran Ben Elisha
2019-02-07 9:36 ` [PATCH v4 net-next 05/11] devlink: Add health set command Eran Ben Elisha
2019-02-07 9:36 ` [PATCH v4 net-next 06/11] devlink: Add health recover command Eran Ben Elisha
2019-02-07 9:36 ` [PATCH v4 net-next 07/11] devlink: Add health diagnose command Eran Ben Elisha
2019-02-07 9:36 ` [PATCH v4 net-next 08/11] devlink: Add health dump {get,clear} commands Eran Ben Elisha
2019-02-07 9:36 ` [PATCH v4 net-next 09/11] net/mlx5e: Add tx reporter support Eran Ben Elisha
2019-02-07 9:36 ` [PATCH v4 net-next 10/11] net/mlx5e: Add tx timeout support for mlx5e tx reporter Eran Ben Elisha
2019-02-07 9:36 ` [PATCH v4 net-next 11/11] devlink: Add Documentation/networking/devlink-health.txt Eran Ben Elisha
2019-02-07 18:37 ` [PATCH v4 net-next 00/11] Devlink health reporting and recovery system David Miller
2019-02-10 18:28 ` [iproute2-next, 0/4] Add support for devlink health Aya Levin
2019-02-10 18:28 ` [PATCH for-next 1/4] devlink: refactor validation of finding required arguments Aya Levin
2019-02-11 2:46 ` David Ahern
2019-02-11 10:29 ` Jiri Pirko
2019-02-10 18:28 ` [PATCH for-next 2/4] devlink: fix print of uint64_t Aya Levin
2019-02-10 20:34 ` Stephen Hemminger
2019-02-11 2:44 ` David Ahern
2019-02-11 10:32 ` Jiri Pirko
2019-02-10 18:28 ` [PATCH for-next 3/4] devlink: fix boolean JSON print Aya Levin
2019-02-10 20:34 ` Stephen Hemminger
2019-02-10 18:28 ` [PATCH for-next 4/4] devlink: add health command support Aya Levin
2019-02-10 20:42 ` Stephen Hemminger [this message]
2019-02-11 10:41 ` Jiri Pirko
2019-02-10 18:35 ` [iproute2-next, 0/4] Add support for devlink health Aya Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190210124222.59c5d0aa@hermes.lan \
--to=stephen@networkplumber.org \
--cc=ariela@mellanox.com \
--cc=ayal@mellanox.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=eranbe@mellanox.com \
--cc=jiri@mellanox.com \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=talal@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).