From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Martin Lau <kafai@fb.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <Kernel-team@fb.com>, Joe Stringer <joe@wand.net.nz>
Subject: Re: [PATCH bpf] bpf: Fix narrow load on a bpf_sock returned from sk_lookup()
Date: Sun, 10 Feb 2019 19:54:00 -0800 [thread overview]
Message-ID: <20190211035358.j4muzcj257bkxkqd@ast-mbp> (raw)
In-Reply-To: <20190210071513.o56emdqcb23xtng3@kafai-mbp.dhcp.thefacebook.com>
On Sun, Feb 10, 2019 at 07:15:17AM +0000, Martin Lau wrote:
> > > Fixes: c64b7983288e ("bpf: Add PTR_TO_SOCKET verifier type")
> > > Cc: Joe Stringer <joe@wand.net.nz>
> > > Signed-off-by: Martin KaFai Lau <kafai@fb.com>
> >
> > Applied to bpf tree.
> Thanks!
>
> >
> > Martin, if your is_fullsock work depends on it, I can apply the fix
> > to bpf-next as well. Just let me know.
> Yes, the is_fullsock work depends on it.
> I should have mentioned it in this commit log.
Ok. I've pushed it to bpf-next as well.
Last time we discusses this scenario at netconf and agreed that git should
do the right thing, since commit is the same.
I think this is a case where I think it makes sense to give it a shot.
If we get issues during pulls/merges it will be a lesson to avoid
such things in the future, but if we don't try it we won't know.
So applied.
prev parent reply other threads:[~2019-02-11 3:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 6:25 [PATCH bpf] bpf: Fix narrow load on a bpf_sock returned from sk_lookup() Martin KaFai Lau
2019-02-10 1:47 ` Joe Stringer
2019-02-10 4:02 ` Alexei Starovoitov
2019-02-10 7:15 ` Martin Lau
2019-02-11 3:54 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211035358.j4muzcj257bkxkqd@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=Kernel-team@fb.com \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=joe@wand.net.nz \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).