From: Luca Boccassi <bluca@debian.org>
To: netdev@vger.kernel.org
Cc: stephen@networkplumber.org, "Luca Boccassi" <bluca@debian.org>,
"Clément Hertling" <wxcafe@wxcafe.net>
Subject: [RFC iproute2] ip route: get: allow zero-length subnet mask
Date: Wed, 13 Feb 2019 20:09:53 +0000 [thread overview]
Message-ID: <20190213200954.32271-1-bluca@debian.org> (raw)
A /0 subnet mask is theoretically valid, but ip route get doesn't allow
it:
$ ip route get 1.0.0.0/0
need at least a destination address
Remove the check so that it can go through:
$ ip/ip route get 1.0.0.0/0
1.0.0.0 via 192.168.1.1 dev eth0 src 192.168.1.91 uid 1000
cache
Reported-by: Clément Hertling <wxcafe@wxcafe.net>
Signed-off-by: Luca Boccassi <bluca@debian.org>
---
Stephen et al, this was reported by a Debian user:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=921737
It makes sense to me at a cursory glance, but sending as RFC as I'm
not 100% familiar with the route get function.
ip/iproute.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/ip/iproute.c b/ip/iproute.c
index 5f58a3b3..d78f43d8 100644
--- a/ip/iproute.c
+++ b/ip/iproute.c
@@ -2041,11 +2041,6 @@ static int iproute_get(int argc, char **argv)
argc--; argv++;
}
- if (req.r.rtm_dst_len == 0) {
- fprintf(stderr, "need at least a destination address\n");
- return -1;
- }
-
if (idev || odev) {
int idx;
--
2.20.1
next reply other threads:[~2019-02-13 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 20:09 Luca Boccassi [this message]
2019-02-13 20:37 ` [RFC iproute2] ip route: get: allow zero-length subnet mask Stephen Hemminger
2019-02-14 23:29 ` [RFC iproute2 v2] " Luca Boccassi
2019-02-19 23:22 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213200954.32271-1-bluca@debian.org \
--to=bluca@debian.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=wxcafe@wxcafe.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).