From: Andrew Lunn <andrew@lunn.ch>
To: Parshuram Thombare <pthombar@cadence.com>
Cc: nicolas.ferre@microchip.com, davem@davemloft.net,
netdev@vger.kernel.org, f.fainelli@gmail.com,
hkallweit1@gmail.com, linux-kernel@vger.kernel.org,
rafalc@cadence.com, piotrs@cadence.com, jank@cadence.com
Subject: Re: [PATCH 3/3] net: ethernet: add support for high speed mac and usxgmii pcs
Date: Fri, 22 Feb 2019 22:44:04 +0100 [thread overview]
Message-ID: <20190222214404.GP5894@lunn.ch> (raw)
In-Reply-To: <20190222201309.GA23470@lvlogina.cadence.com>
> if (macb_is_gem(bp)) {
> - linkmode_copy(phydev->supported, PHY_GBIT_FEATURES);
> - if (bp->caps & MACB_CAPS_TWO_PT_FIVE_GIG_SPEED)
> - linkmode_set_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT,
> - phydev->supported);
> + if (bp->caps & MACB_CAPS_HIGH_SPEED) {
> + linkmode_copy(phydev->supported, PHY_10GBIT_FEATURES);
> + } else {
> + u32 bitmask = ETHTOOL_LINK_MODE_2500baseT_Full_BIT;
> +
> + linkmode_copy(phydev->supported, PHY_GBIT_FEATURES);
> + if (bp->caps & MACB_CAPS_TWO_PT_FIVE_GIG_SPEED)
> + linkmode_set_bit(bitmask, phydev->supported);
> + }
Same issue again. Somebody could be using a 10G MAC with a 2.5G PHY.
Andrew
next prev parent reply other threads:[~2019-02-22 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 20:13 [PATCH 3/3] net: ethernet: add support for high speed mac and usxgmii pcs Parshuram Thombare
2019-02-22 21:44 ` Andrew Lunn [this message]
2019-02-23 6:24 ` Parshuram Raju Thombare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222214404.GP5894@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=piotrs@cadence.com \
--cc=pthombar@cadence.com \
--cc=rafalc@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).