From: David Miller <davem@davemloft.net>
To: lucien.xin@gmail.com
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
marcelo.leitner@gmail.com, nhorman@tuxdriver.com,
mcroce@redhat.com, vdronov@redhat.com
Subject: Re: [PATCH net-next 0/2] sctp: fully support memory accounting
Date: Thu, 04 Apr 2019 10:38:36 -0700 (PDT) [thread overview]
Message-ID: <20190404.103836.99803631681096896.davem@davemloft.net> (raw)
In-Reply-To: <CADvbK_cZ6q7k8X_7=SYzXKRkwXVZAHGBejxPSgK0vkUNcoktXA@mail.gmail.com>
From: Xin Long <lucien.xin@gmail.com>
Date: Thu, 4 Apr 2019 17:45:07 +0800
> We're thinking about adding some sctp tests into selftests,
> but these ones are not good to be the first one, I think.
> sysctl_sockets_memctl.sh is a multi-host test, even netns can't work for it.
You can't set per-netns memory controls appropriately to make the
tests work?
> Each subcomponent seems to have its own test case in other git repo,
> can I ask what kind of tests should I put into kernel selftests in
> the future?
It would be ideal that we have a decent base set of SCTP tests and
then when bug fixes are added, we get a unit test with the fix.
I guess a good baseline would be testing basic comminucation between
SCTP sockets in different netns, and then adding tests for setting
the various socket options and making sure the socket option had the
desired effect.
next prev parent reply other threads:[~2019-04-04 17:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 8:53 [PATCH net-next 0/2] sctp: fully support memory accounting Xin Long
2019-03-31 8:53 ` [PATCH net-next 1/2] sctp: implement memory accounting on tx path Xin Long
2019-03-31 8:53 ` [PATCH net-next 2/2] sctp: implement memory accounting on rx path Xin Long
2019-04-02 11:48 ` Marcelo Ricardo Leitner
2019-04-02 11:48 ` [PATCH net-next 1/2] sctp: implement memory accounting on tx path Marcelo Ricardo Leitner
2019-03-31 8:56 ` [PATCH net-next 0/2] sctp: fully support memory accounting Xin Long
2019-03-31 18:02 ` David Miller
2019-04-04 9:45 ` Xin Long
2019-04-04 17:38 ` David Miller [this message]
2019-04-05 4:49 ` Xin Long
2019-03-31 19:22 ` Matteo Croce
2019-03-31 20:10 ` Marcelo Ricardo Leitner
2019-03-31 21:04 ` David Miller
2019-04-01 7:25 ` Xin Long
2019-04-01 11:31 ` Neil Horman
2019-04-02 3:36 ` Marcelo Ricardo Leitner
2019-04-02 11:41 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404.103836.99803631681096896.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).