From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F12EC282DC for ; Wed, 17 Apr 2019 20:52:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 05998217FA for ; Wed, 17 Apr 2019 20:52:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="wR66wtQl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731215AbfDQUwP (ORCPT ); Wed, 17 Apr 2019 16:52:15 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:37580 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbfDQUwN (ORCPT ); Wed, 17 Apr 2019 16:52:13 -0400 Received: by mail-qt1-f196.google.com with SMTP id z16so29033719qtn.4 for ; Wed, 17 Apr 2019 13:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qpi+EskD3e2MasShacmTD+72iAzHwK9N6qZu+Lqco7M=; b=wR66wtQlkd4Fsp8pcX7fm2wLJMtofQkRpI6ocRAyOlIHGlu4qNK039RPcCyfW7ALiz 5w8XR10DGLrVC2bW2gvtiO15bku4AXBY8y+ZUaYaHNeOhwlFjcsysBQG42LIlGRzBZUy C8Zt4Oieo9Bee/XHQODOPlZlNK8hA+re8YJUdSZ8j5DiNNrvlpA6OrHoV2P9T0Q1fkIF Xr6r+UnYi9i0bqpPmL3yRpZYS+CgBsNpqChi6ZBHYfXIH0RSfMaioW50T2p+yHrnzKCW W273Rkax5tC/q+rgqk23Z+vgfl2k9qb9IACBjHyy5SAP5xN0OP5kT0c+EZL4RsjY4A5u JA0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qpi+EskD3e2MasShacmTD+72iAzHwK9N6qZu+Lqco7M=; b=IGvW2HBV7gcS5Y/5l4QSIqLcdEUlQ5TNS6zj7xvd2WPfcItkEyg578Nk2g0PxGmf17 VNxtC2v+5d2EV1tl8W1GmKKyHVvhM6MCKa+R62w+XoGjpbYM7c83iWNhk9O+xvaHbIVv XZGdcnyahpuFs85VteJmcMz9wNLl4dkzXfZ/G9n/2oE2Z4WRNHCSUTlgNkGgXgnbYQCY FU3EPHwFaX+Zj+pD4xoSlIwPlT0NFyfmAcEWLEkoJzr0dL09qO2YgMcWNP/svoTrR1hC tG4Ed7QUhSRrFRePYjfr56TyFzy4gHa25DTXDjLjCLPichSClJsz88U5mg29tEcrOICn SP+Q== X-Gm-Message-State: APjAAAUeWOZSgTpBNwbXn301uu3zW75c9Lp3uNumGsVtuU9chY2SrZNQ dsej6vlv39rTdaEae6mJYROw1Q== X-Google-Smtp-Source: APXvYqyV2HpiMce3wbGZLWGPKwLzNp5bHj5HzI6CF98h6mRFI9SCP5T31Gz4FmnZoIm96X1AkqKPPg== X-Received: by 2002:a0c:ba10:: with SMTP id w16mr73792759qvf.115.1555534332501; Wed, 17 Apr 2019 13:52:12 -0700 (PDT) Received: from jkicinski-Precision-T1700.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id d34sm60247qta.18.2019.04.17.13.52.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Apr 2019 13:52:12 -0700 (PDT) From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, Jakub Kicinski , Dirk van der Merwe , James Chapman Subject: [PATCH net-next 1/5] l2tp: fix set but not used variable Date: Wed, 17 Apr 2019 13:51:55 -0700 Message-Id: <20190417205159.30938-2-jakub.kicinski@netronome.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190417205159.30938-1-jakub.kicinski@netronome.com> References: <20190417205159.30938-1-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org GCC complains: net/l2tp/l2tp_ppp.c: In function ‘pppol2tp_ioctl’: net/l2tp/l2tp_ppp.c:1073:6: warning: variable ‘val’ set but not used [-Wunused-but-set-variable] int val; ^~~ Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- CC: James Chapman net/l2tp/l2tp_ppp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/l2tp/l2tp_ppp.c b/net/l2tp/l2tp_ppp.c index 04d9946dcdba..f36cae785e82 100644 --- a/net/l2tp/l2tp_ppp.c +++ b/net/l2tp/l2tp_ppp.c @@ -1070,7 +1070,6 @@ static int pppol2tp_ioctl(struct socket *sock, unsigned int cmd, { struct pppol2tp_ioc_stats stats; struct l2tp_session *session; - int val; switch (cmd) { case PPPIOCGMRU: @@ -1097,7 +1096,7 @@ static int pppol2tp_ioctl(struct socket *sock, unsigned int cmd, if (!session->session_id && !session->peer_session_id) return -ENOSYS; - if (get_user(val, (int __user *)arg)) + if (!access_ok((int __user *)arg, sizeof(int))) return -EFAULT; break; -- 2.21.0