From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71A0DC282DA for ; Fri, 19 Apr 2019 19:58:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1FE9B20821 for ; Fri, 19 Apr 2019 19:58:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727353AbfDST6c (ORCPT ); Fri, 19 Apr 2019 15:58:32 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:37624 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725820AbfDST6c (ORCPT ); Fri, 19 Apr 2019 15:58:32 -0400 Received: by mail-wr1-f66.google.com with SMTP id w10so8085169wrm.4 for ; Fri, 19 Apr 2019 12:58:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/wjTGakZnNojUmw2/x3D/pIu5NJQy3DjANvcrxJYaXc=; b=GPzaJmLYTIEAV1XuaSEUZZn2eYmBsg/ffV9YU+xZasysoKCwgpSy/SFEJtmh3PQO/d CTosA9AsFB9p8GBwpKpnCwqHSZOjo+AmQ7C3fy91EiZ3mKNpOM9YuBWDBHJdA3z+c5zu nUdX0n8e6tzFmr9WhXYgGe5i8uI5Alix1eqKBHkQyEiY0w1FTcAKbM5+UPV/O7kedRXu N9bB6+onvzehN9URjJ4y3pXtOo9o7su1rPYRJD+qCpYLg8ukNDlFj83rV+dBOaGOtvc7 GuHttc3Xjyrk44NsLW+jZGlqC2QDg9JV2Icg0D0peeUyaUDbtfSLwM+MZGkQHBstgxmd hBmg== X-Gm-Message-State: APjAAAXXrZml57CSjffrA54nMq7T8rzAcqJfQNSEyOn43LqljvDCeMYW Af6jfoPLrq4YXRWoxFsHPDgVwgc4770= X-Google-Smtp-Source: APXvYqxILlZcmlbSagDo9agZOopwKbtgHBohsT2dL6uMK5p1HdBPpn/EB4nbvBDkvCF1/RBldHPNPg== X-Received: by 2002:adf:db46:: with SMTP id f6mr1085115wrj.64.1555663109465; Fri, 19 Apr 2019 01:38:29 -0700 (PDT) Received: from pc-2.home (2a01cb05850ddf00045dd60e6368f84b.ipv6.abo.wanadoo.fr. [2a01:cb05:850d:df00:45d:d60e:6368:f84b]) by smtp.gmail.com with ESMTPSA id u8sm3731767wrt.69.2019.04.19.01.38.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Apr 2019 01:38:28 -0700 (PDT) Date: Fri, 19 Apr 2019 10:38:26 +0200 From: Guillaume Nault To: Jakub Kicinski Cc: David Miller , netdev@vger.kernel.org, oss-drivers@netronome.com, Guillaume Nault Subject: Re: [PATCH net-next 0/5] net: some build fixes and other improvements Message-ID: <20190419083825.GA19272@pc-2.home> References: <20190417205159.30938-1-jakub.kicinski@netronome.com> <20190418.170647.73605480308402367.davem@davemloft.net> <20190418173407.3909143b@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190418173407.3909143b@cakuba.netronome.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 18, 2019 at 05:34:07PM -0700, Jakub Kicinski wrote: > On Thu, 18 Apr 2019 17:06:47 -0700 (PDT), David Miller wrote: > > From: Jakub Kicinski > > Date: Wed, 17 Apr 2019 13:51:54 -0700 > > > > > A few unrelated improvements here, mostly trying to make random > > > configs build and W=1 produce a little less warnings under net/ > > > and drivers net/. > > > > > > First two patches fix set but not used warnings with W=1. > > > > > > Next patch fixes 64bit division in sch_taprio.c. > > > > > > Last two patches are getting rid of some (almost) unused asserts > > > in skbuff.h. > > > > Series applied, thanks Jakub. > > Thanks! > > > That l2tp one was weird, apparently that value was never ever used. > > Yess, the only explanation I could come up with was that Guillaume > wanted to make sure user space passed a valid pointer, even if it's > unused today. But that's pure speculation :S Exactly. These ioctl commands didn't make sense and had no effect. I didn't remove them because they had been part of the ABI for so long. Maintaining the behaviour for invalid pointers was probably a bit overzealous though. I missed your patch, will rework my mail filters. Anyway thanks for taking care of that. Guillaume