netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Carolyn Wyborny <carolyn.wyborny@intel.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	Andrew Bowers <andrewx.bowers@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next v2 01/11] i40e: Fix for allowing too many MDD events on VF
Date: Fri,  3 May 2019 16:09:29 -0700	[thread overview]
Message-ID: <20190503230939.6739-2-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20190503230939.6739-1-jeffrey.t.kirsher@intel.com>

From: Carolyn Wyborny <carolyn.wyborny@intel.com>

This patch changes the driver behavior when detecting a VF MDD event.
It now disables the VF after one event, which indicates a hw detected
problem in the VF.  Before this change, the PF would allow a couple of
events before doing the reset.

Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 65c2b9d2652b..b52a9d5644b8 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -9767,6 +9767,9 @@ static void i40e_handle_mdd_event(struct i40e_pf *pf)
 			vf->num_mdd_events++;
 			dev_info(&pf->pdev->dev, "TX driver issue detected on VF %d\n",
 				 i);
+			dev_info(&pf->pdev->dev,
+				 "Use PF Control I/F to re-enable the VF\n");
+			set_bit(I40E_VF_STATE_DISABLED, &vf->vf_states);
 		}
 
 		reg = rd32(hw, I40E_VP_MDET_RX(i));
@@ -9775,11 +9778,6 @@ static void i40e_handle_mdd_event(struct i40e_pf *pf)
 			vf->num_mdd_events++;
 			dev_info(&pf->pdev->dev, "RX driver issue detected on VF %d\n",
 				 i);
-		}
-
-		if (vf->num_mdd_events > I40E_DEFAULT_NUM_MDD_EVENTS_ALLOWED) {
-			dev_info(&pf->pdev->dev,
-				 "Too many MDD events on VF %d, disabled\n", i);
 			dev_info(&pf->pdev->dev,
 				 "Use PF Control I/F to re-enable the VF\n");
 			set_bit(I40E_VF_STATE_DISABLED, &vf->vf_states);
-- 
2.20.1


  reply	other threads:[~2019-05-03 23:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-03 23:09 [net-next v2 00/11][pull request] 40GbE Intel Wired LAN Driver Updates 2019-05-03 Jeff Kirsher
2019-05-03 23:09 ` Jeff Kirsher [this message]
2019-05-03 23:09 ` [net-next v2 02/11] i40e: change behavior on PF in response to MDD event Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 03/11] i40e: remove error msg when vf with port vlan tries to remove vlan 0 Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 04/11] i40e: ShadowRAM checksum calculation change Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 05/11] i40e: Report advertised link modes on 40GBase_LR4, CR4 and fibre Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 06/11] i40e: Further implementation of LLDP Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 07/11] i40e: remove out-of-range comparisons in i40e_validate_cloud_filter Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 08/11] i40e: update version number Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 09/11] i40e: fix misleading message about promisc setting on un-trusted VF Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 10/11] i40e: print PCI vendor and device ID during probe Jeff Kirsher
2019-05-03 23:09 ` [net-next v2 11/11] i40e: Introduce recovery mode support Jeff Kirsher
2019-05-04 11:35   ` Jakub Kicinski
2019-05-05  1:23     ` Jeff Kirsher
2019-05-07 18:51     ` Michael, Alice
2019-05-07 21:22       ` Jakub Kicinski
2019-05-04  3:32 ` [net-next v2 00/11][pull request] 40GbE Intel Wired LAN Driver Updates 2019-05-03 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190503230939.6739-2-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=andrewx.bowers@intel.com \
    --cc=carolyn.wyborny@intel.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).