From: Andrew Lunn <andrew@lunn.ch>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: netdev@vger.kernel.org, netdev@vger.kernel-org,
schmitz@debian.org, davem@davemloft.net, sfr@canb.auug.org.au
Subject: Re: [PATCH v2] net: phy: rename Asix Electronics PHY driver
Date: Sat, 18 May 2019 16:20:10 +0200 [thread overview]
Message-ID: <20190518142010.GL14298@lunn.ch> (raw)
In-Reply-To: <1558142095-20307-1-git-send-email-schmitzmic@gmail.com>
On Sat, May 18, 2019 at 01:14:55PM +1200, Michael Schmitz wrote:
> Commit 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver")
> introduced a new PHY driver drivers/net/phy/asix.c that causes a module
> name conflict with a pre-existiting driver (drivers/net/usb/asix.c).
>
> The PHY driver is used by the X-Surf 100 ethernet card driver, and loaded
> by that driver via its PHY ID. A rename of the driver looks unproblematic.
>
> Rename PHY driver to ax88796b.c in order to resolve name conflict.
>
> Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
> Fixes: 31dd83b96641 ("net-next: phy: new Asix Electronics PHY driver")
> ---
>
> Changes from v1:
>
> - merge into single commit (suggested by Andrew Lunn)
Hi Michael
There is a flag you can pass to git which will make it issue a rename,
rather than delete and then add. That will make the patch much
smaller.
net-next is closed at the moment.
http://vger.kernel.org/~davem/net-next.html
Once it reopens, please send a v3, and it will be merged.
Thanks
Andrew
next prev parent reply other threads:[~2019-05-18 14:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190514105649.512267cd@canb.auug.org.au>
2019-05-17 20:25 ` [PATCH 0/3] resolve module name conflict for asix PHY and USB modules Michael Schmitz
2019-05-17 21:20 ` Andrew Lunn
2019-05-18 1:17 ` Michael Schmitz
2019-05-17 20:25 ` [PATCH 1/3] net: phy: new ax88796b.c Asix Electronics PHY driver Michael Schmitz
2019-05-17 20:25 ` [PATCH 2/3] net: 8390: switch X-Surf 100 driver to use ax88796b PHY Michael Schmitz
2019-05-17 20:25 ` [PATCH 3/3] net: phy: remove old Asix Electronics PHY driver Michael Schmitz
2019-05-18 1:14 ` [PATCH v2] net: phy: rename " Michael Schmitz
2019-05-18 14:20 ` Andrew Lunn [this message]
2019-05-18 17:48 ` Michael Schmitz
2019-05-18 18:04 ` Andrew Lunn
2019-06-07 5:37 ` [PATCH net v3] " Michael Schmitz
2019-06-07 13:00 ` Andrew Lunn
2019-06-08 1:54 ` Michael Schmitz
2019-06-09 20:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190518142010.GL14298@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel-org \
--cc=netdev@vger.kernel.org \
--cc=schmitz@debian.org \
--cc=schmitzmic@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).