From: David Miller <davem@davemloft.net>
To: vladbu@mellanox.com
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, daniel@iogearbox.net
Subject: Re: [PATCH net-next] net: sched: ingress: set 'unlocked' flag for clsact Qdisc ops
Date: Fri, 14 Jun 2019 19:34:07 -0700 (PDT) [thread overview]
Message-ID: <20190614.193407.464864156424103215.davem@davemloft.net> (raw)
In-Reply-To: <20190613161205.2689-1-vladbu@mellanox.com>
From: Vlad Buslov <vladbu@mellanox.com>
Date: Thu, 13 Jun 2019 19:12:05 +0300
> To remove rtnl lock dependency in tc filter update API when using clsact
> Qdisc, set QDISC_CLASS_OPS_DOIT_UNLOCKED flag in clsact Qdisc_class_ops.
>
> Clsact Qdisc ops don't require any modifications to be used without rtnl
> lock on tc filter update path. Implementation never changes its q->block
> and only releases it when Qdisc is being destroyed. This means it is enough
> for RTM_{NEWTFILTER|DELTFILTER|GETTFILTER} message handlers to hold clsact
> Qdisc reference while using it without relying on rtnl lock protection.
> Unlocked Qdisc ops support is already implemented in filter update path by
> unlocked cls API patch set.
>
> Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Applied.
prev parent reply other threads:[~2019-06-15 2:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 16:12 [PATCH net-next] net: sched: ingress: set 'unlocked' flag for clsact Qdisc ops Vlad Buslov
2019-06-15 2:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614.193407.464864156424103215.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@iogearbox.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=vladbu@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).