From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Paul Blakey" <paulb@mellanox.com>,
"Jiri Pirko" <jiri@mellanox.com>, "Roi Dayan" <roid@mellanox.com>,
"Yossi Kuperman" <yossiku@mellanox.com>,
"Oz Shlomo" <ozsh@mellanox.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David Miller" <davem@davemloft.net>,
"Aaron Conole" <aconole@redhat.com>,
"Zhike Wang" <wangzhike@jd.com>,
"Rony Efraim" <ronye@mellanox.com>,
"nst-kernel@redhat.com" <nst-kernel@redhat.com>,
"John Hurley" <john.hurley@netronome.com>,
"Simon Horman" <simon.horman@netronome.com>,
"Justin Pettit" <jpettit@ovn.org>,
"Kevin Darbyshire-Bryant" <kevin@darbyshire-bryant.me.uk>
Subject: Re: [PATCH net-next 1/3] net/sched: Introduce action ct
Date: Fri, 14 Jun 2019 16:24:03 -0300 [thread overview]
Message-ID: <20190614192403.GK3436@localhost.localdomain> (raw)
In-Reply-To: <CAM_iQpX1jFBYCLu1t+SbuxKDMr3_c2Fip0APwLebO9tf_hqs8w@mail.gmail.com>
On Fri, Jun 14, 2019 at 11:07:37AM -0700, Cong Wang wrote:
> On Tue, Jun 11, 2019 at 9:44 AM Marcelo Ricardo Leitner
> <marcelo.leitner@gmail.com> wrote:
> > I had suggested to let act_ct handle the above as well, as there is a
> > big chunk of code on both that is pretty similar. There is quite some
> > boilerplate for interfacing with conntrack which is duplicated.
>
> Why do you want to mix retrieving conntrack info with executing
> conntrack?
To save on the heavy boilerplate for interfacing with conntrack.
>
> They are totally different things to me, act_ctinfo merely retrieves
> information from conntrack, while this one, act_ct, is supposed to
> move packets to conntrack.
Seems we have a different understanding for "move packets to
conntrack": conntrack will not consume the packets after this.
But after act_ct is executed, if not with the clear flag, skb will now
have the skb->_nfct entry available, on which flower then will be able
to match. So in essence, it is also fetching information from
conntrack.
I see act_ctinfo is a subset of what act_ct is doing.
Marcelo
next prev parent reply other threads:[~2019-06-14 19:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 13:28 [PATCH net-next 0/3] net/sched: Introduce tc connection tracking Paul Blakey
2019-06-11 13:28 ` [PATCH net-next 1/3] net/sched: Introduce action ct Paul Blakey
2019-06-11 13:59 ` Toke Høiland-Jørgensen
2019-06-11 14:15 ` Paul Blakey
2019-06-11 15:34 ` Toke Høiland-Jørgensen
2019-06-11 15:53 ` Marcelo Ricardo Leitner
2019-06-11 20:23 ` Toke Høiland-Jørgensen
2019-06-13 13:46 ` Paul Blakey
2019-06-13 14:08 ` Toke Høiland-Jørgensen
2019-06-14 18:07 ` Cong Wang
2019-06-14 19:24 ` Marcelo Ricardo Leitner [this message]
2019-06-18 16:03 ` Cong Wang
2019-06-20 7:32 ` Paul Blakey
2019-06-24 17:46 ` Cong Wang
2019-06-13 11:00 ` Kevin Darbyshire-Bryant
2019-06-12 18:04 ` Marcelo Ricardo Leitner
2019-06-13 13:44 ` Paul Blakey
2019-06-12 19:55 ` Florian Westphal
2019-06-13 13:39 ` Paul Blakey
2019-06-13 10:16 ` Davide Caratti
2019-06-13 10:49 ` Davide Caratti
2019-06-13 13:40 ` Paul Blakey
2019-06-14 18:02 ` Cong Wang
2019-06-16 7:29 ` Paul Blakey
2019-06-19 18:33 ` Marcelo Ricardo Leitner
2019-06-20 7:07 ` Paul Blakey
2019-06-11 13:28 ` [PATCH net-next 2/3] net/flow_dissector: add connection tracking dissection Paul Blakey
2019-06-11 13:28 ` [PATCH net-next 3/3] net/sched: cls_flower: Add matching on conntrack info Paul Blakey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614192403.GK3436@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=john.hurley@netronome.com \
--cc=jpettit@ovn.org \
--cc=kevin@darbyshire-bryant.me.uk \
--cc=netdev@vger.kernel.org \
--cc=nst-kernel@redhat.com \
--cc=ozsh@mellanox.com \
--cc=paulb@mellanox.com \
--cc=roid@mellanox.com \
--cc=ronye@mellanox.com \
--cc=simon.horman@netronome.com \
--cc=toke@redhat.com \
--cc=wangzhike@jd.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yossiku@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).