From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
john.fastabend@gmail.com, vakul.garg@nxp.com,
borisp@mellanox.com, alexei.starovoitov@gmail.com,
dirk.vandermerwe@netronome.com
Subject: Re: [PATCH net] net/tls: fix page double free on TX cleanup
Date: Mon, 24 Jun 2019 07:21:34 -0700 (PDT) [thread overview]
Message-ID: <20190624.072134.1587556039627335168.davem@davemloft.net> (raw)
In-Reply-To: <20190624042658.19198-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Sun, 23 Jun 2019 21:26:58 -0700
> From: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
>
> With commit 94850257cf0f ("tls: Fix tls_device handling of partial records")
> a new path was introduced to cleanup partial records during sk_proto_close.
> This path does not handle the SW KTLS tx_list cleanup.
>
> This is unnecessary though since the free_resources calls for both
> SW and offload paths will cleanup a partial record.
>
> The visible effect is the following warning, but this bug also causes
> a page double free.
...
> Fixes: 94850257cf0f ("tls: Fix tls_device handling of partial records")
> Signed-off-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2019-06-24 14:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 4:26 [PATCH net] net/tls: fix page double free on TX cleanup Jakub Kicinski
2019-06-24 14:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624.072134.1587556039627335168.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexei.starovoitov@gmail.com \
--cc=borisp@mellanox.com \
--cc=dirk.vandermerwe@netronome.com \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).