From: David Miller <davem@davemloft.net>
To: ndesaulniers@google.com
Cc: nicolas.dichtel@6wind.com, netdev@vger.kernel.org, lkp@intel.com
Subject: Re: [PATCH net v2 1/2] ipv6: constify rt6_nexthop()
Date: Mon, 24 Jun 2019 10:22:12 -0700 (PDT) [thread overview]
Message-ID: <20190624.102212.4398258272798722.davem@davemloft.net> (raw)
In-Reply-To: <CAKwvOdmd2AooQrpPhBVhcRHGNsMoGFiXSyBA4_aBf7=oVeOx1g@mail.gmail.com>
From: Nick Desaulniers <ndesaulniers@google.com>
Date: Mon, 24 Jun 2019 10:17:03 -0700
> On Mon, Jun 24, 2019 at 10:06 AM David Miller <davem@davemloft.net> wrote:
>>
>> From: Nick Desaulniers <ndesaulniers@google.com>
>> Date: Mon, 24 Jun 2019 09:45:14 -0700
>>
>> > https://groups.google.com/forum/#!searchin/clang-built-linux/const%7Csort:date/clang-built-linux/umkS84jS9m8/GAVVEgNYBgAJ
>>
>> Inaccessible...
>>
>> This group either doesn't exist, or you don't have permission
>> to access it. If you're sure this group exists, contact the
>> Owner of the group and ask them to give you access.
>
> Sorry, I set up the mailing list not too long ago, seem to have a long
> tail of permissions related issues. I confirmed that the link was
> borked in an incognito window. Via
> https://support.google.com/a/answer/9325317#Visibility I was able to
> change the obscure setting. I now confirmed the above link works in
> an incognito window. Thanks for reporting; can you please triple
> check?
Yep it works now, thanks.
>>
>> And you mean just changing to 'const' fixes something, how?
>
> See the warning in the above link (assuming now you have access).
> Assigning a non-const variable the result of a function call that
> returns const discards the const qualifier.
Ok thanks for clarifying.
However I was speaking in terms of this fixing a functional bug rather
than a loss of const warning.
next prev parent reply other threads:[~2019-06-24 17:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 12:34 [PATCH net] ipv6: fix neighbour resolution with raw socket Nicolas Dichtel
2019-06-20 15:12 ` David Ahern
2019-06-20 15:42 ` Nicolas Dichtel
2019-06-20 16:36 ` David Ahern
2019-06-20 16:47 ` David Ahern
2019-06-21 8:09 ` Nicolas Dichtel
2019-06-21 18:48 ` kbuild test robot
2019-06-23 0:07 ` David Miller
2019-06-23 0:08 ` David Miller
2019-06-24 14:01 ` [PATCH net v2 0/2] " Nicolas Dichtel
2019-06-24 14:01 ` [PATCH net v2 1/2] ipv6: constify rt6_nexthop() Nicolas Dichtel
2019-06-24 16:45 ` Nick Desaulniers
2019-06-24 17:06 ` David Miller
2019-06-24 17:17 ` Nick Desaulniers
2019-06-24 17:22 ` David Miller [this message]
2019-06-24 17:37 ` Nick Desaulniers
2019-06-24 18:18 ` Nicolas Dichtel
2019-06-24 20:27 ` David Miller
2019-06-24 14:01 ` [PATCH net v2 2/2] ipv6: fix neighbour resolution with raw socket Nicolas Dichtel
2019-06-26 20:26 ` [PATCH net v2 0/2] " David Miller
2019-10-14 9:34 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624.102212.4398258272798722.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lkp@intel.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).