From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Parshuram Raju Thombare <pthombar@cadence.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rafal Ciepiela <rafalc@cadence.com>,
Piotr Sroka <piotrs@cadence.com>,
Anil Joy Varughese <aniljoy@cadence.com>,
Arthur Marris <arthurm@cadence.com>,
Steven Ho <stevenh@cadence.com>,
Milind Parab <mparab@cadence.com>
Subject: Re: [PATCH v6 0/5] net: macb: cover letter
Date: Thu, 25 Jul 2019 14:36:00 +0100 [thread overview]
Message-ID: <20190725133559.GI1330@shell.armlinux.org.uk> (raw)
In-Reply-To: <CO2PR07MB246961335F7D401785377765C1C10@CO2PR07MB2469.namprd07.prod.outlook.com>
On Thu, Jul 25, 2019 at 01:27:58PM +0000, Parshuram Raju Thombare wrote:
> Hi Andrew,
>
> >One thing which was never clear is how you are testing the features you are
> >adding. Please could you describe your test setup and how each new feature
> >is tested using that hardware. I'm particularly interested in what C45 device
> >are you using? But i expect Russell would like to know more about SFP
> >modules you are using. Do you have any which require 1000BaseX,
> >2500BaseX, or provide copper 1G?
>
> Sorry for late reply.
> Here is a little more information on our setup used for testing C45 patch with a view to
> try clarify a few points.
> Regarding the MDIO communication channel that our controller supports - We have tested
> MDIO transfers through Clause 22, but none of our local PHY's support Clause 45 so our hardware
> team have created an example Clause 45 slave device for us to add support to the driver.
> Note our hardware has been in silicon for 20 years, with customers using their own software to support
> MDIO (both clause 22 and clause 45 functionality) and so this has been in Cadence's hardware controller
> many times.
> The programming interface is not hugely different between the two clauses and therefore we feel the risk is low.
>
> For other features like SGMII, USXGMII we are using kc705 and vcu118 FPGA boards.
> 10G SFP+ module from Tyco electronics is used for testing 10G USXGMII in fixed AN mode.
SFP and SFP+ modules take SGMII, 1000BASE-X, possibly 2500BASE-X and
10GBASE-R all over a single serdes lane.
USXGMII might be used from the MAC to some sort of PHY which then
converts to 10GBASE-R.
If you have a PHY present, then using phylink and trying to link the
MAC directly with the SFP cage in software is the _wrong approach_.
I've stated this several times.
I'm getting to the point of asking you not to persist with your use
of phylink with your driver - I do not believe that your hardware has
any justification for its use, and I also believe that your use of
phylink is positively hurtful to the long term maintenance of phylink
itself.
In other words, you persisting to (ab)use phylink _hurts_ our ability
to maintain it into the future.
I'm also at the point where I'm giving up reviewing your patches - you
don't seem to take the issues I raise on board at all, so I feel like
I'm completely wasting my time trying to get you to make improvements.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-07-25 13:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 14:36 [PATCH v6 0/5] net: macb: cover letter Parshuram Thombare
2019-07-10 14:37 ` [PATCH v6 1/4] net: macb: add phylink support Parshuram Thombare
2019-07-10 14:38 ` [PATCH v6 2/4] net: macb: add support for sgmii MAC-PHY interface Parshuram Thombare
2019-07-10 14:38 ` [PATCH v6 3/4] net: macb: add support for c45 PHY Parshuram Thombare
2019-07-10 14:39 ` [PATCH v6 4/4] net: macb: add support for high speed interface Parshuram Thombare
2019-07-10 18:47 ` [PATCH v6 0/5] net: macb: cover letter David Miller
2019-07-11 5:20 ` Parshuram Raju Thombare
2019-07-18 15:13 ` Andrew Lunn
2019-07-25 13:27 ` Parshuram Raju Thombare
2019-07-25 13:36 ` Russell King - ARM Linux admin [this message]
2019-07-25 13:48 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725133559.GI1330@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=aniljoy@cadence.com \
--cc=arthurm@cadence.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mparab@cadence.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=piotrs@cadence.com \
--cc=pthombar@cadence.com \
--cc=rafalc@cadence.com \
--cc=stevenh@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).