From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: David Ahern <dsahern@kernel.org>,
davem@davemloft.net, netdev@vger.kernel.org,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries
Date: Wed, 7 Aug 2019 08:27:12 +0200 [thread overview]
Message-ID: <20190807062712.GE2332@nanopsycho.orion> (raw)
In-Reply-To: <20190806153214.25203a68@cakuba.netronome.com>
Wed, Aug 07, 2019 at 12:32:14AM CEST, jakub.kicinski@netronome.com wrote:
>On Tue, 6 Aug 2019 12:15:17 -0700, David Ahern wrote:
>> From: David Ahern <dsahern@gmail.com>
>>
>> Prior to the commit in the fixes tag, the resource controller in netdevsim
>> tracked fib entries and rules per network namespace. Restore that behavior.
>>
>> Fixes: 5fc494225c1e ("netdevsim: create devlink instance per netdevsim instance")
>> Signed-off-by: David Ahern <dsahern@gmail.com>
>
>Thanks.
>
>Let's see what Jiri says, but to me this patch seems to indeed restore
>the original per-namespace accounting when the more natural way forward
>may perhaps be to make nsim only count the fib entries where
I think that:
1) netdevsim is a glorified dummy device for testing kernel api, not for
configuring per-namespace resource limitation.
2) If the conclusion os to use devlink instead of cgroups for resourse
limitations, it should be done in a separate code, not in netdevsim.
I would definitelly want to wait what is the result of discussion around 2)
first. But one way or another netdevsim code should not do this, I would
like to cutout the fib limitations from it instead, just to expose the
setup resource limits through debugfs like the rest of the configuration
of netdevsim.
>
> fib_info->net == devlink_net(devlink)
>
>> -void nsim_fib_destroy(struct nsim_fib_data *data)
>> +int nsim_fib_init(void)
>> {
>> - unregister_fib_notifier(&data->fib_nb);
>> - kfree(data);
>> + int err;
>> +
>> + err = register_pernet_subsys(&nsim_fib_net_ops);
>> + if (err < 0) {
>> + pr_err("Failed to register pernet subsystem\n");
>> + goto err_out;
>> + }
>> +
>> + err = register_fib_notifier(&nsim_fib_nb, nsim_fib_dump_inconsistent);
>> + if (err < 0) {
>> + pr_err("Failed to register fib notifier\n");
>
> unregister_pernet_subsys(&nsim_fib_net_ops);
>?
>
>> + goto err_out;
>> + }
>> +
>> +err_out:
>> + return err;
>> }
next prev parent reply other threads:[~2019-08-07 6:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 19:15 [PATCH net] netdevsim: Restore per-network namespace accounting for fib entries David Ahern
2019-08-06 22:32 ` Jakub Kicinski
2019-08-07 6:27 ` Jiri Pirko [this message]
2019-08-07 12:39 ` David Ahern
2019-08-07 13:07 ` Jiri Pirko
2019-08-07 19:31 ` David Ahern
2019-08-12 4:02 ` David Miller
2019-08-12 8:36 ` Jiri Pirko
2019-08-12 15:28 ` David Miller
2019-08-13 7:14 ` Jiri Pirko
2019-08-13 14:41 ` David Ahern
2019-08-13 15:34 ` Jiri Pirko
2019-08-13 17:40 ` David Miller
2019-08-13 20:37 ` Jiri Pirko
2019-08-28 10:37 ` Jiri Pirko
2019-08-28 21:26 ` David Ahern
2019-08-29 6:28 ` Jiri Pirko
2019-08-29 12:54 ` David Ahern
2019-08-29 14:02 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807062712.GE2332@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).