From: Leo Yan <leo.yan@linaro.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, clang-built-linux@googlegroups.com,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Suzuki Poulouse <suzuki.poulose@arm.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5] perf machine: arm/arm64: Improve completeness for kernel address space
Date: Wed, 4 Sep 2019 16:59:12 +0800 [thread overview]
Message-ID: <20190904085912.GA27922@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <c16ee888-73cc-588d-6156-bb5528d635cf@intel.com>
Hi Adrian,
On Wed, Sep 04, 2019 at 10:26:13AM +0300, Adrian Hunter wrote:
[...]
> > Could you take chance to review my below replying? I'd like to get
> > your confirmation before I send out offical patch.
>
> It is not necessary to do kallsyms__parse for x86_64, so it would be better
> to check the arch before calling that.
Thanks for suggestion, will do it in the formal patch.
> However in general, having to copy and use kallsyms with perf.data if on a
> different arch does not seem very user friendly.
Agree. Seems it's more reasonable to save related info in
perf.data; TBH, I have no idea for how to do that.
> But really that is up to Arnaldo.
@Arnaldo, if possible could you take a look for below change?
If you don't think below code is the right thing and it's not a common
issue, then maybe it's more feasible to resolve this issue only for
Arm CoreSight specific.
Please let me know how about you think for this?
Thanks,
Leo Yan
> >> For your question for taking a perf.data file to a machine with a
> >> different architecture, we can firstly use command 'perf buildid-list'
> >> to print out the buildid for kallsyms, based on the dumped buildid we
> >> can find out the location for the saved kallsyms file; then we can use
> >> option '--kallsyms' to specify the offline kallsyms file and use the
> >> offline kallsyms to fixup kernel start address. The detailed commands
> >> are listed as below:
> >>
> >> root@debian:~# perf buildid-list
> >> 7b36dfca8317ef74974ebd7ee5ec0a8b35c97640 [kernel.kallsyms]
> >> 56b84aa88a1bcfe222a97a53698b92723a3977ca /usr/lib/systemd/systemd
> >> 0956b952e9cd673d48ff2cfeb1a9dbd0c853e686 /usr/lib/aarch64-linux-gnu/libm-2.28.so
> >> [...]
> >>
> >> root@debian:~# perf script --kallsyms ~/.debug/\[kernel.kallsyms\]/7b36dfca8317ef74974ebd7ee5ec0a8b35c97640/kallsyms
> >>
> >> The amended patch is as below, please review and always welcome
> >> any suggestions or comments!
> >>
> >> diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> >> index 5734460fc89e..593f05cc453f 100644
> >> --- a/tools/perf/util/machine.c
> >> +++ b/tools/perf/util/machine.c
> >> @@ -2672,9 +2672,26 @@ int machine__nr_cpus_avail(struct machine *machine)
> >> return machine ? perf_env__nr_cpus_avail(machine->env) : 0;
> >> }
> >>
> >> +static int machine__fixup_kernel_start(void *arg,
> >> + const char *name __maybe_unused,
> >> + char type,
> >> + u64 start)
> >> +{
> >> + struct machine *machine = arg;
> >> +
> >> + type = toupper(type);
> >> +
> >> + /* Fixup for text, weak, data and bss sections. */
> >> + if (type == 'T' || type == 'W' || type == 'D' || type == 'B')
> >> + machine->kernel_start = min(machine->kernel_start, start);
> >> +
> >> + return 0;
> >> +}
> >> +
> >> int machine__get_kernel_start(struct machine *machine)
> >> {
> >> struct map *map = machine__kernel_map(machine);
> >> + char filename[PATH_MAX];
> >> int err = 0;
> >>
> >> /*
> >> @@ -2696,6 +2713,22 @@ int machine__get_kernel_start(struct machine *machine)
> >> if (!err && !machine__is(machine, "x86_64"))
> >> machine->kernel_start = map->start;
> >> }
> >> +
> >> + if (symbol_conf.kallsyms_name != NULL) {
> >> + strncpy(filename, symbol_conf.kallsyms_name, PATH_MAX);
> >> + } else {
> >> + machine__get_kallsyms_filename(machine, filename, PATH_MAX);
> >> +
> >> + if (symbol__restricted_filename(filename, "/proc/kallsyms"))
> >> + goto out;
> >> + }
> >> +
> >> + if (kallsyms__parse(filename, machine, machine__fixup_kernel_start))
> >> + pr_warning("Fail to fixup kernel start address. skipping...\n");
> >> +
> >> +out:
> >> return err;
> >> }
> >>
> >>
> >> Thanks,
> >> Leo Yan
> >
>
prev parent reply other threads:[~2019-09-04 8:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 8:25 [PATCH v5] perf machine: arm/arm64: Improve completeness for kernel address space Leo Yan
2019-08-15 8:54 ` Adrian Hunter
2019-08-15 11:32 ` Leo Yan
2019-08-15 11:45 ` Adrian Hunter
2019-08-16 1:45 ` Leo Yan
2019-08-16 13:00 ` Adrian Hunter
2019-08-26 12:51 ` Leo Yan
2019-09-02 14:15 ` Leo Yan
2019-09-04 7:26 ` Adrian Hunter
2019-09-04 8:59 ` Leo Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904085912.GA27922@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=coresight@lists.linaro.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@redhat.com \
--cc=kafai@fb.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=suzuki.poulose@arm.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).