From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEAA2C4360C for ; Thu, 10 Oct 2019 04:10:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B706A20B7C for ; Thu, 10 Oct 2019 04:10:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="NRIKTQ/5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727595AbfJJEKv (ORCPT ); Thu, 10 Oct 2019 00:10:51 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:36421 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbfJJEKu (ORCPT ); Thu, 10 Oct 2019 00:10:50 -0400 Received: by mail-pf1-f193.google.com with SMTP id y22so3022417pfr.3 for ; Wed, 09 Oct 2019 21:10:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=UJcSHYkyLS9g2HcZpoI2PRpiUanA4ZgkPXLt3MeRjlU=; b=NRIKTQ/5lVzZlZ+BGZEXIz0+tR+zTp5Hyl4nM7s6qwfmPzgPapCL2040GvTsv9+t/H AumM73/yfgwYwujTL7Gy6csJOI9BvkVwYdeUI3IVDP9897uDZCYXT+qdTKyaY7zqeI/U BpseQISF4WC4GGxmW/9BLlDcLMeKAj054hJmbECKCUzEkUX2RxwdbX2454Na4pgS/ORk BjLH1I5BtPXOEyI10iBu1T+vxY55jW3TsZ+HCK8f1+0q/3cLRqfm6mjuon3xfRQE1MEN bJLa8t+K0DQxeMhop9VoBr67HGJ12sT/xSD65B2HG9Fi3kfEGO5V1Z3m1TWW19NRmlDz XEJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=UJcSHYkyLS9g2HcZpoI2PRpiUanA4ZgkPXLt3MeRjlU=; b=U4Gb43GiL4oS5eT52+rAqo1D/iToWKji9kQDwbnjtbbvli/oZKraqpa0wcBt9PuDoR lqiDePBKkW/vMSCkZQVhcS3sReWgY2I2TuRPG8oxgMWWS6sPkYpmRmZTIPDM8g64e6Ey tIb1O4Z7PG7zqeTyZQ5BdAdc7RYr7qLe5khXGfS3fZXpw7Kf56Dp2RFFnWpFXvm98QOv NvqeNCipSzV194QKeLZo4QI5KKbfbMtGR147I2IyQw6QSnZVjMj2wEOpRYSjWLLVtG/K hiWmcMSml76lL14xCk5mP3NuEcjWJNme3HtRMd3kdki6ioxr54ooJrejfFDh7iLKf+Fm soPQ== X-Gm-Message-State: APjAAAVs0yB7kwGaIK3VfGZbpzxbSpnnKWhVBjXHxRx0NTQ4NuCo6bP6 T5lTkTLbsL/2Ve+HRYOysmHgPXJZLa4= X-Google-Smtp-Source: APXvYqxIpkjNG0HuZBQUpsyPMQikG470tsb4kk2XRUCpUECWCfEvE6VkDu3bSw/SJQXnrD/BpN+RIg== X-Received: by 2002:a17:90a:9f42:: with SMTP id q2mr8591781pjv.95.1570680650051; Wed, 09 Oct 2019 21:10:50 -0700 (PDT) Received: from cakuba.netronome.com (c-73-202-202-92.hsd1.ca.comcast.net. [73.202.202.92]) by smtp.gmail.com with ESMTPSA id q3sm4049200pgj.54.2019.10.09.21.10.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 21:10:49 -0700 (PDT) Date: Wed, 9 Oct 2019 21:10:37 -0700 From: Jakub Kicinski To: Ben Dooks Cc: linux-kernel@lists.codethink.co.uk, "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/ethernet: xgmac don't set .driver twice Message-ID: <20191009211037.2db1c1b6@cakuba.netronome.com> In-Reply-To: <20191009132627.316-1-ben.dooks@codethink.co.uk> References: <20191009132627.316-1-ben.dooks@codethink.co.uk> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 9 Oct 2019 14:26:27 +0100, Ben Dooks wrote: > Cleanup the .driver setup to just do it once, to avoid > the following sparse warning: > > drivers/net/ethernet/calxeda/xgmac.c:1914:10: warning: Initializer entry defined twice > drivers/net/ethernet/calxeda/xgmac.c:1920:10: also defined here > > Signed-off-by: Ben Dooks Applied, thanks