From: David Miller <davem@davemloft.net>
To: ecree@solarflare.com
Cc: lucien.xin@gmail.com, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com,
nhorman@tuxdriver.com, brouer@redhat.com, dvyukov@google.com,
syzkaller-bugs@googlegroups.com
Subject: Re: Stable request
Date: Wed, 16 Oct 2019 13:47:47 -0400 (EDT) [thread overview]
Message-ID: <20191016.134747.1774326347358314168.davem@davemloft.net> (raw)
In-Reply-To: <fa2e9f70-05bd-bcac-e502-8bdb375163ce@solarflare.com>
From: Edward Cree <ecree@solarflare.com>
Date: Wed, 16 Oct 2019 16:26:50 +0100
> On 04/10/2019 16:17, Edward Cree wrote:
>> On 23/08/2019 22:42, David Miller wrote:
>>> From: Xin Long <lucien.xin@gmail.com>
>>> Date: Fri, 23 Aug 2019 19:33:03 +0800
>>>
>>>> We need a similar fix for ipv6 as Commit 0761680d5215 ("net: ipv4: fix
>>>> listify ip_rcv_finish in case of forwarding") does for ipv4.
>>>>
>>>> This issue can be reprocuded by syzbot since Commit 323ebb61e32b ("net:
>>>> use listified RX for handling GRO_NORMAL skbs") on net-next. The call
>>>> trace was:
>>> ...
>>>> Fixes: d8269e2cbf90 ("net: ipv6: listify ipv6_rcv() and ip6_rcv_finish()")
>>>> Fixes: 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL skbs")
>>>> Reported-by: syzbot+eb349eeee854e389c36d@syzkaller.appspotmail.com
>>>> Reported-by: syzbot+4a0643a653ac375612d1@syzkaller.appspotmail.com
>>>> Signed-off-by: Xin Long <lucien.xin@gmail.com>
>>> Applied, thanks.
>> Just noticed that this only went to net-next (and 5.4-rc1), when actually
>> it's needed on all kernels back to 4.19 (per the first Fixes: tag). The
>> second Fixes: reference, 323ebb61e32b, merely enables syzbot to hit it on
>> whatever hardware it has, but the bug was already there, and hittable on
>> sfc NICs.
>> David, can this go to stable please?
> Hi, did this get missed or was my request improper in some way?
Sorry, I'm just getting over a cold and very backlogged on this kind of stuff.
I'll get to this while I can Ed.
next prev parent reply other threads:[~2019-10-16 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 11:33 [PATCH net-next] net: ipv6: fix listify ip6_rcv_finish in case of forwarding Xin Long
2019-08-23 12:07 ` Edward Cree
2019-08-23 21:42 ` David Miller
2019-10-04 15:17 ` Edward Cree
2019-10-16 15:26 ` Stable request (was Re: [PATCH net-next] net: ipv6: fix listify ip6_rcv_finish in case of forwarding) Edward Cree
2019-10-16 17:47 ` David Miller [this message]
2019-10-17 23:50 ` Stable request David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016.134747.1774326347358314168.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brouer@redhat.com \
--cc=dvyukov@google.com \
--cc=ecree@solarflare.com \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).