From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4FDECA9EB7 for ; Wed, 23 Oct 2019 10:31:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F91F20679 for ; Wed, 23 Oct 2019 10:31:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="b+PMNTWd"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="BdJTj+l9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404492AbfJWKbM (ORCPT ); Wed, 23 Oct 2019 06:31:12 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:36998 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404361AbfJWKbM (ORCPT ); Wed, 23 Oct 2019 06:31:12 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0BFBD60930; Wed, 23 Oct 2019 10:31:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1571826671; bh=A7PH/myWbf3inKtiwdNO1H56o0VQY99LFEVNO9VJcYI=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=b+PMNTWdS5DOqqkGKvYp2t6oxZ/dXXyLkHo+IRWyH6WilDLax4HfBK98xeHRMFgtg cYk6tvk/ySvQaVsGZytvVz0+gqXcb3k8cbQjTSZ4sncD+2/4EvfpBZHgsZeDW838JR /vz1oSxkWXLwxAR4eNoBv5hyMlGCfmmTu4hNA9kE= Received: from potku.adurom.net (unknown [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7EFF460159; Wed, 23 Oct 2019 10:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1571826670; bh=A7PH/myWbf3inKtiwdNO1H56o0VQY99LFEVNO9VJcYI=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=BdJTj+l9l+3+2vg6/W+RoAoS/4bkEnbl6+SPdTIPVduhbF/kVckJ5z3dpvZufKzZ/ hjA9FNNQu2BA/aDtUDILqOJlfjrjyf2rjh8lYdvkeQhRcl8DwuHO0blNuT1I6CTF3M ygIHGL8X0YhJ6oUgfiPr5StwpPtoOJv/VA+DLaPE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7EFF460159 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] rtlwifi: Fix potential overflow on P2P code From: Kalle Valo In-Reply-To: <20191018114321.13131-1-labbott@redhat.com> References: <20191018114321.13131-1-labbott@redhat.com> To: Laura Abbott Cc: Ping-Ke Shih , Laura Abbott , "David S . Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Waisman User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20191023103111.0BFBD60930@smtp.codeaurora.org> Date: Wed, 23 Oct 2019 10:31:11 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Laura Abbott wrote: > Nicolas Waisman noticed that even though noa_len is checked for > a compatible length it's still possible to overrun the buffers > of p2pinfo since there's no check on the upper bound of noa_num. > Bound noa_num against P2P_MAX_NOA_NUM. > > Reported-by: Nicolas Waisman > Signed-off-by: Laura Abbott > Acked-by: Ping-Ke Shih Patch applied to wireless-drivers.git, thanks. 8c55dedb795b rtlwifi: Fix potential overflow on P2P code -- https://patchwork.kernel.org/patch/11198315/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches