From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Bruce Allan <bruce.w.allan@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Andrew Bowers <andrewx.bowers@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next v2 09/15] ice: use pkg_dwnld_status instead of sq_last_status
Date: Fri, 8 Nov 2019 12:38:00 -0800 [thread overview]
Message-ID: <20191108203806.12109-10-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20191108203806.12109-1-jeffrey.t.kirsher@intel.com>
From: Bruce Allan <bruce.w.allan@intel.com>
Since the return value from the Download Package AQ command is stored in
hw->pkg_dwnld_status, use that instead of sq_last_status since that may
have the return value from some other AQ command leading to unexpected
results.
Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index cb93fe5529f6..4f4ebb499559 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -2900,7 +2900,7 @@ ice_log_pkg_init(struct ice_hw *hw, enum ice_status *status)
ICE_PKG_SUPP_VER_MAJ, ICE_PKG_SUPP_VER_MNR);
break;
case ICE_ERR_AQ_ERROR:
- switch (hw->adminq.sq_last_status) {
+ switch (hw->pkg_dwnld_status) {
case ICE_AQ_RC_ENOSEC:
case ICE_AQ_RC_EBADSIG:
dev_err(dev,
--
2.21.0
next prev parent reply other threads:[~2019-11-08 20:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 20:37 [net-next v2 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-11-08 Jeff Kirsher
2019-11-08 20:37 ` [net-next v2 01/15] ice: Use ice_ena_vsi and ice_dis_vsi in DCB configuration flow Jeff Kirsher
2019-11-08 20:37 ` [net-next v2 02/15] ice: Add NDO callback to set the maximum per-queue bitrate Jeff Kirsher
2019-11-08 20:37 ` [net-next v2 03/15] ice: Implement DCBNL support Jeff Kirsher
2019-11-08 20:37 ` [net-next v2 04/15] ice: avoid setting features during reset Jeff Kirsher
2019-11-08 20:37 ` [net-next v2 05/15] ice: Fix to change Rx/Tx ring descriptor size via ethtool with DCBx Jeff Kirsher
2019-11-08 20:37 ` [net-next v2 06/15] ice: configure software LLDP in ice_init_pf_dcb Jeff Kirsher
2019-11-08 20:37 ` [net-next v2 07/15] ice: Check if VF is disabled for Opcode and other operations Jeff Kirsher
2019-11-08 20:37 ` [net-next v2 08/15] ice: Change max MSI-x vector_id check in cfg_irq_map Jeff Kirsher
2019-11-08 20:38 ` Jeff Kirsher [this message]
2019-11-08 20:38 ` [net-next v2 10/15] ice: delay less Jeff Kirsher
2019-11-08 20:38 ` [net-next v2 11/15] ice: Update enum ice_flg64_bits to current specification Jeff Kirsher
2019-11-08 20:38 ` [net-next v2 12/15] ice: remove unnecessary conditional check Jeff Kirsher
2019-11-08 20:38 ` [net-next v2 13/15] ice: Introduce and use ice_vsi_type_str Jeff Kirsher
2019-11-08 20:38 ` [net-next v2 14/15] ice: use more accurate ICE_DBG mask types Jeff Kirsher
2019-11-08 20:38 ` [net-next v2 15/15] ice: print opcode when printing controlq errors Jeff Kirsher
2019-11-08 21:54 ` [net-next v2 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-11-08 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108203806.12109-10-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=andrewx.bowers@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).