From: Jonathan Lemon <jonathan.lemon@gmail.com>
To: <netdev@vger.kernel.org>, <brouer@redhat.com>,
<ilias.apalodimas@linaro.org>
Cc: <kernel-team@fb.com>
Subject: [RFC PATCH 0/1] Change page_pool timeout handling
Date: Sun, 10 Nov 2019 22:20:37 -0800 [thread overview]
Message-ID: <20191111062038.2336521-1-jonathan.lemon@gmail.com> (raw)
It isn't safe to remove the page pool until all in-flight pages
are returned. If the pages are handed up the stack, it might be
a while before they are returned.
The page pool can also be used independently of xdp, so it shouldn't
be depending on timeout handling from xdp. Change things around so
the pool handles its own timeout.
I wanted to send this out to clarify how I see things working. This
is currently being tested with the mlx4/mlx5 drivers for attaching
DMA-mapped pages to skbs, sending them up the stack, and then putting
them back in the page pool afterwards.
Jonathan Lemon (1):
page_pool: do not release pool until inflight == 0.
.../net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +-
include/net/page_pool.h | 55 +++-----
include/net/xdp_priv.h | 4 -
include/trace/events/xdp.h | 19 +--
net/core/page_pool.c | 115 ++++++++++------
net/core/xdp.c | 130 +++++++-----------
6 files changed, 138 insertions(+), 189 deletions(-)
--
2.17.1
next reply other threads:[~2019-11-11 6:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 6:20 Jonathan Lemon [this message]
2019-11-11 6:20 ` [RFC PATCH 1/1] page_pool: do not release pool until inflight == 0 Jonathan Lemon
2019-11-11 9:21 ` Jesper Dangaard Brouer
2019-11-11 16:16 ` Jonathan Lemon
2019-11-11 11:47 ` Jesper Dangaard Brouer
2019-11-11 14:04 ` Ilias Apalodimas
2019-11-12 6:00 ` Jonathan Lemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111062038.2336521-1-jonathan.lemon@gmail.com \
--to=jonathan.lemon@gmail.com \
--cc=brouer@redhat.com \
--cc=ilias.apalodimas@linaro.org \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).