From: Andrew Lunn <andrew@lunn.ch>
To: Nicolas.Ferre@microchip.com
Cc: mparab@cadence.com, antoine.tenart@bootlin.com,
davem@davemloft.net, netdev@vger.kernel.org,
f.fainelli@gmail.com, hkallweit1@gmail.com,
linux-kernel@vger.kernel.org, dkangude@cadence.com,
pthombar@cadence.com, rmk+kernel@arm.linux.org.uk
Subject: Re: [PATCH 2/3] net: macb: add support for C45 MDIO read/write
Date: Wed, 27 Nov 2019 19:51:29 +0100 [thread overview]
Message-ID: <20191127185129.GU6602@lunn.ch> (raw)
In-Reply-To: <19694e5a-17df-608f-5db7-5da288e5e7cd@microchip.com>
On Wed, Nov 27, 2019 at 06:31:54PM +0000, Nicolas.Ferre@microchip.com wrote:
> On 26/11/2019 at 15:37, Andrew Lunn wrote:
> > On Tue, Nov 26, 2019 at 09:09:49AM +0000, Milind Parab wrote:
> >> This patch modify MDIO read/write functions to support
> >> communication with C45 PHY.
> >
> > I think i've asked this before, at least once, but you have not added
> > it to the commit messages. Do all generations of the macb support C45?
>
> For what I can tell from the different IP revisions that we implemented
> throughout the years in Atmel then Microchip products (back to
> at91rm9200 and at91sam9263), it seems yes.
>
> The "PHY Maintenance Register" "MACB_MAN_*" was always present with the
> same bits 32-28 layout (with somehow different names).
>
> But definitively we would need to hear that from Cadence itself which
> would be far better.
Hi Nicolas
Thanks, that is useful.
I'm just trying to avoid backward compatibility issues, somebody
issues a C45 request on old silicon and it all goes horribly wrong.
Andrew
next prev parent reply other threads:[~2019-11-27 18:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 9:09 [PATCH 0/3] net: macb: cover letter Milind Parab
2019-11-26 9:09 ` [PATCH 1/3] net: macb: fix for fixed-link mode Milind Parab
2019-11-26 14:30 ` Andrew Lunn
2019-11-27 18:02 ` Nicolas.Ferre
2019-11-28 6:50 ` Milind Parab
2019-11-26 9:09 ` [PATCH 2/3] net: macb: add support for C45 MDIO read/write Milind Parab
2019-11-26 14:37 ` Andrew Lunn
2019-11-27 18:31 ` Nicolas.Ferre
2019-11-27 18:51 ` Andrew Lunn [this message]
2019-11-28 8:29 ` Milind Parab
2019-11-28 14:52 ` Andrew Lunn
2019-11-29 10:02 ` Milind Parab
2019-11-26 9:09 ` [PATCH 3/3] net: macb: add support for high speed interface Milind Parab
2019-11-26 18:09 ` [PATCH 0/3] net: macb: cover letter David Miller
2019-12-09 11:13 [PATCH 0/3] net: macb: fix for fixed link, support for c45 mdio and 10G Milind Parab
2019-12-09 11:15 ` [PATCH 2/3] net: macb: add support for C45 MDIO read/write Milind Parab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127185129.GU6602@lunn.ch \
--to=andrew@lunn.ch \
--cc=Nicolas.Ferre@microchip.com \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=dkangude@cadence.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mparab@cadence.com \
--cc=netdev@vger.kernel.org \
--cc=pthombar@cadence.com \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).