From: David Miller <davem@davemloft.net>
To: olteanv@gmail.com
Cc: richardcochran@gmail.com, andrew@lunn.ch, f.fainelli@gmail.com,
vivien.didelot@gmail.com, claudiu.manoil@nxp.com,
alexandru.marginean@nxp.com, xiaoliang.yang_1@nxp.com,
yangbo.lu@nxp.com, netdev@vger.kernel.org,
alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com,
vladimir.oltean@nxp.com, antoine.tenart@bootlin.com
Subject: Re: [PATCH v2 net] net: mscc: ocelot: unregister the PTP clock on deinit
Date: Thu, 28 Nov 2019 23:13:14 -0800 (PST) [thread overview]
Message-ID: <20191128.231314.78069224750097408.davem@davemloft.net> (raw)
In-Reply-To: <20191128112342.2547-1-olteanv@gmail.com>
From: Vladimir Oltean <olteanv@gmail.com>
Date: Thu, 28 Nov 2019 13:23:42 +0200
> +static void ocelot_deinit_timestamp(struct ocelot *ocelot)
> +{
> + if (ocelot->ptp_clock)
> + ptp_clock_unregister(ocelot->ptp_clock);
> +}
No need for a helper function, you're calling this in only _one_ place.
prev parent reply other threads:[~2019-11-29 7:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 11:23 [PATCH v2 net] net: mscc: ocelot: unregister the PTP clock on deinit Vladimir Oltean
2019-11-29 3:55 ` Y.b. Lu
2019-11-29 7:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128.231314.78069224750097408.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandru.marginean@nxp.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=claudiu.manoil@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=richardcochran@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).