From: Steffen Klassert <steffen.klassert@secunet.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 4/4] udp: Support UDP fraglist GRO/GSO.
Date: Thu, 19 Dec 2019 09:26:02 +0100 [thread overview]
Message-ID: <20191219082602.GT8621@gauss3.secunet.de> (raw)
In-Reply-To: <CA+FuTScaqg8whAaS35n9TT+=7S38Sn_sMEN=KstYF6i83keSsw@mail.gmail.com>
On Wed, Dec 18, 2019 at 11:03:09AM -0500, Willem de Bruijn wrote:
> On Wed, Dec 18, 2019 at 8:35 AM Steffen Klassert
> <steffen.klassert@secunet.com> wrote:
>
> > @@ -544,6 +585,18 @@ INDIRECT_CALLABLE_SCOPE int udp4_gro_complete(struct sk_buff *skb, int nhoff)
> > const struct iphdr *iph = ip_hdr(skb);
> > struct udphdr *uh = (struct udphdr *)(skb->data + nhoff);
> >
> > + if (NAPI_GRO_CB(skb)->is_flist) {
> > + uh->len = htons(skb->len - nhoff);
> > +
> > + skb_shinfo(skb)->gso_type |= (SKB_GSO_FRAGLIST|SKB_GSO_UDP_L4);
> > + skb_shinfo(skb)->gso_segs = NAPI_GRO_CB(skb)->count;
> > +
> > + skb->ip_summed = CHECKSUM_UNNECESSARY;
> > + skb->csum_level = ~0;
>
> why is this needed for ipv4 only?
It is needed for IPv6 too, I've just forgot to add it there.
Thanks for the review!
prev parent reply other threads:[~2019-12-19 8:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 13:34 [PATCH net-next 0/4] Support fraglist GRO/GSO Steffen Klassert
2019-12-18 13:34 ` [PATCH net-next 1/4] net: Add fraglist GRO/GSO feature flags Steffen Klassert
2019-12-18 16:02 ` Willem de Bruijn
2019-12-18 13:34 ` [PATCH net-next 2/4] net: Add a netdev software feature set that defaults to off Steffen Klassert
2019-12-18 16:02 ` Willem de Bruijn
2019-12-18 13:34 ` [PATCH net-next 3/4] net: Support GRO/GSO fraglist chaining Steffen Klassert
2019-12-18 16:02 ` Willem de Bruijn
2019-12-19 8:22 ` Steffen Klassert
2019-12-19 16:28 ` Willem de Bruijn
2020-01-13 8:51 ` Steffen Klassert
2020-01-13 16:21 ` Willem de Bruijn
2020-01-15 9:47 ` Steffen Klassert
2020-01-15 15:43 ` Willem de Bruijn
2020-01-20 8:35 ` Steffen Klassert
2020-01-20 16:35 ` Willem de Bruijn
2019-12-18 13:34 ` [PATCH net-next 4/4] udp: Support UDP fraglist GRO/GSO Steffen Klassert
2019-12-18 16:03 ` Willem de Bruijn
2019-12-19 8:26 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219082602.GT8621@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=subashab@codeaurora.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).