From: Jakub Kicinski <kubakici@wp.pl>
To: Johan Hovold <johan@kernel.org>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] NFC: pn533: fix bulk-message timeout
Date: Mon, 13 Jan 2020 18:56:15 -0800 [thread overview]
Message-ID: <20200113185615.5aa7720a@cakuba> (raw)
In-Reply-To: <20200113172358.30973-1-johan@kernel.org>
On Mon, 13 Jan 2020 18:23:58 +0100, Johan Hovold wrote:
> The driver was doing a synchronous uninterruptible bulk-transfer without
> using a timeout. This could lead to the driver hanging on probe due to a
> malfunctioning (or malicious) device until the device is physically
> disconnected. While sleeping in probe the driver prevents other devices
> connected to the same hub from being added to (or removed from) the bus.
>
> An arbitrary limit of five seconds should be more than enough.
>
> Fixes: dbafc28955fa ("NFC: pn533: don't send USB data off of the stack")
> Cc: stable <stable@vger.kernel.org> # 4.18
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Applied to net, thank you. In the future please don't CC stable
explicitly on networking patches, Dave (or I) will select and send
all relevant patches to stable as noted in netdev FAQ.
prev parent reply other threads:[~2020-01-14 2:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 17:23 [PATCH] NFC: pn533: fix bulk-message timeout Johan Hovold
2020-01-13 18:25 ` Greg Kroah-Hartman
2020-01-14 2:56 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113185615.5aa7720a@cakuba \
--to=kubakici@wp.pl \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).