From: Andrew Lunn <andrew@lunn.ch>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com,
hkallweit1@gmail.com, kernel@pengutronix.de
Subject: Re: [PATCH] net: phy: dp83867: Set FORCE_LINK_GOOD do default after reset
Date: Tue, 14 Jan 2020 14:25:02 +0100 [thread overview]
Message-ID: <20200114132502.GH11788@lunn.ch> (raw)
In-Reply-To: <20200114112425.19967-1-m.grzeschik@pengutronix.de>
Hi Michael
> @@ -635,6 +636,16 @@ static int dp83867_phy_reset(struct phy_device *phydev)
>
> usleep_range(10, 20);
>
> + /* After reset FORCE_LINK_GOOD bit is set. Although the
> + * default value should be unset. Disable FORCE_LINK_GOOD
> + * for the phy to work properly.
> + */
> + val = phy_read(phydev, MII_DP83867_PHYCTRL);
> + if (val & DP83867_PHYCR_FORCE_LINK_GOOD) {
> + val &= ~(DP83867_PHYCR_FORCE_LINK_GOOD);
> + phy_write(phydev, MII_DP83867_PHYCTRL, val);
> + }
You could use phy_modify().
Andrew
next prev parent reply other threads:[~2020-01-14 13:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 11:24 [PATCH] net: phy: dp83867: Set FORCE_LINK_GOOD do default after reset Michael Grzeschik
2020-01-14 13:25 ` Andrew Lunn [this message]
2020-01-14 16:45 ` [PATCH v2] net: phy: dp83867: Set FORCE_LINK_GOOD to " Michael Grzeschik
2020-01-14 19:21 ` Heiner Kallweit
2020-01-15 8:01 ` [PATCH v3] " Michael Grzeschik
2020-01-16 12:57 ` David Miller
2020-01-16 13:16 ` [PATCH v4] " Michael Grzeschik
2020-01-16 23:48 ` Andrew Lunn
2020-01-17 10:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114132502.GH11788@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=m.grzeschik@pengutronix.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).