From: David Miller <davem@davemloft.net>
To: Jason@zx2c4.com
Cc: netdev@vger.kernel.org, chenzhou10@huawei.com, hulkci@huawei.com
Subject: Re: [PATCH net] icmp: allow icmpv6_ndo_send to work with CONFIG_IPV6=n
Date: Tue, 25 Feb 2020 11:02:05 -0800 (PST) [thread overview]
Message-ID: <20200225.110205.1860690641020290592.davem@davemloft.net> (raw)
In-Reply-To: <20200225100535.45146-1-Jason@zx2c4.com>
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: Tue, 25 Feb 2020 18:05:35 +0800
> The icmpv6_send function has long had a static inline implementation
> with an empty body for CONFIG_IPV6=n, so that code calling it doesn't
> need to be ifdef'd. The new icmpv6_ndo_send function, which is intended
> for drivers as a drop-in replacement with an identical function
> signature, should follow the same pattern. Without this patch, drivers
> that used to work with CONFIG_IPV6=n now result in a linker error.
>
> Cc: Chen Zhou <chenzhou10@huawei.com>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 0b41713b6066 ("icmp: introduce helper for nat'd source address in network device context")
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Applied, thanks Jason.
prev parent reply other threads:[~2020-02-25 19:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 10:05 [PATCH net] icmp: allow icmpv6_ndo_send to work with CONFIG_IPV6=n Jason A. Donenfeld
2020-02-25 19:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225.110205.1860690641020290592.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jason@zx2c4.com \
--cc=chenzhou10@huawei.com \
--cc=hulkci@huawei.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).