From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, saeedm@mellanox.com,
leon@kernel.org, michael.chan@broadcom.com, vishal@chelsio.com,
jeffrey.t.kirsher@intel.com, idosch@mellanox.com,
aelior@marvell.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, pablo@netfilter.org,
ecree@solarflare.com, mlxsw@mellanox.com
Subject: Re: [patch net-next v2 03/12] flow_offload: check for basic action hw stats type
Date: Tue, 3 Mar 2020 12:46:24 +0100 [thread overview]
Message-ID: <20200303114624.GG2178@nanopsycho> (raw)
In-Reply-To: <20200302113319.22fb0cb1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Mon, Mar 02, 2020 at 08:33:19PM CET, kuba@kernel.org wrote:
>On Sun, 1 Mar 2020 10:00:09 +0100 Jiri Pirko wrote:
>> Sat, Feb 29, 2020 at 08:18:48PM CET, kuba@kernel.org wrote:
>> >On Sat, 29 Feb 2020 08:40:04 +0100 Jiri Pirko wrote:
>> >> Fri, Feb 28, 2020 at 08:40:56PM CET, kuba@kernel.org wrote:
>> >> >On Fri, 28 Feb 2020 18:24:56 +0100 Jiri Pirko wrote:
>> >> >> @@ -299,6 +300,9 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,
>> >> >> return -EINVAL;
>> >> >> }
>> >> >>
>> >> >> + if (!flow_action_basic_hw_stats_types_check(flow_action, extack))
>> >> >> + return -EOPNOTSUPP;
>> >> >
>> >> >Could we have this helper take one stat type? To let drivers pass the
>> >> >stat type they support?
>> >>
>> >> That would be always "any" as "any" is supported by all drivers.
>> >> And that is exactly what the helper checks..
>> >
>> >I'd think most drivers implement some form of DELAYED today, 'cause for
>> >the number of flows things like OvS need that's the only practical one.
>> >I was thinking to let drivers pass DELAYED here.
>> >
>> >I agree that your patch would most likely pass ANY in almost all cases
>> >as you shouldn't be expected to know all the drivers, but at least the
>> >maintainers can easily just tweak the parameter.
>> >
>> >Does that make sense? Maybe I'm missing something.
>>
>> Well, I guess. mlx5 only supports "delayed". It would work for it.
>> How about having flow_action_basic_hw_stats_types_check() as is and
>> add flow_action_basic_hw_stats_types_check_ext() that would accept extra
>> arg with enum?
>
>SGTM, perhaps with a more concise name?
>Just flow_basic_hw_stats_check()?
Will try :)
next prev parent reply other threads:[~2020-03-03 11:46 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 17:24 [patch net-next v2 00/12] net: allow user specify TC action HW stats type Jiri Pirko
2020-02-28 17:24 ` [patch net-next v2 01/12] flow_offload: Introduce offload of " Jiri Pirko
2020-02-29 19:29 ` Pablo Neira Ayuso
2020-03-01 8:44 ` Jiri Pirko
2020-03-02 13:20 ` Pablo Neira Ayuso
2020-03-02 13:58 ` Jiri Pirko
2020-03-02 16:29 ` Edward Cree
2020-03-02 19:24 ` Pablo Neira Ayuso
2020-03-02 20:18 ` Jakub Kicinski
2020-03-02 21:46 ` Pablo Neira Ayuso
2020-03-02 22:49 ` Jakub Kicinski
2020-03-03 17:25 ` Pablo Neira Ayuso
2020-03-03 19:34 ` Jakub Kicinski
2020-03-03 18:55 ` Edward Cree
2020-03-03 19:26 ` Jakub Kicinski
2020-03-03 20:27 ` Pablo Neira Ayuso
2020-03-03 21:06 ` Edward Cree
2020-03-03 21:25 ` Pablo Neira Ayuso
2020-03-03 19:13 ` Edward Cree
2020-03-04 14:18 ` Jiri Pirko
2020-02-28 17:24 ` [patch net-next v2 02/12] ocelot_flower: use flow_offload_has_one_action() helper Jiri Pirko
2020-02-29 0:50 ` Vladimir Oltean
2020-02-28 17:24 ` [patch net-next v2 03/12] flow_offload: check for basic action hw stats type Jiri Pirko
2020-02-28 19:40 ` Jakub Kicinski
2020-02-29 7:40 ` Jiri Pirko
2020-02-29 19:18 ` Jakub Kicinski
2020-03-01 9:00 ` Jiri Pirko
2020-03-02 19:33 ` Jakub Kicinski
2020-03-03 11:46 ` Jiri Pirko [this message]
2020-02-28 17:24 ` [patch net-next v2 04/12] mlx5: en_tc: Do not allow mixing HW stats types for actions Jiri Pirko
2020-02-28 17:24 ` [patch net-next v2 05/12] mlxsw: spectrum_flower: " Jiri Pirko
2020-02-28 17:24 ` [patch net-next v2 06/12] mlx5: restrict supported HW stats type to "any" Jiri Pirko
2020-02-28 17:25 ` [patch net-next v2 07/12] mlxsw: " Jiri Pirko
2020-02-28 17:25 ` [patch net-next v2 08/12] flow_offload: introduce "immediate" HW stats type and allow it in mlxsw Jiri Pirko
2020-02-29 19:32 ` Pablo Neira Ayuso
2020-03-01 8:47 ` Jiri Pirko
2020-03-02 13:23 ` Pablo Neira Ayuso
2020-03-02 13:59 ` Jiri Pirko
2020-02-28 17:25 ` [patch net-next v2 09/12] flow_offload: introduce "delayed" HW stats type and allow it in mlx5 Jiri Pirko
2020-02-28 17:25 ` [patch net-next v2 10/12] mlxsw: spectrum_acl: Ask device for rule stats only if counter was created Jiri Pirko
2020-02-28 17:25 ` [patch net-next v2 11/12] flow_offload: introduce "disabled" HW stats type and allow it in mlxsw Jiri Pirko
2020-02-28 17:25 ` [patch net-next v2 12/12] sched: act: allow user to specify type of HW stats for a filter Jiri Pirko
2020-02-28 19:59 ` Jakub Kicinski
2020-02-29 7:52 ` Jiri Pirko
2020-02-29 20:14 ` Jakub Kicinski
2020-03-01 8:57 ` Jiri Pirko
2020-03-02 19:39 ` Jakub Kicinski
2020-03-03 13:20 ` Jiri Pirko
2020-03-03 19:48 ` Jakub Kicinski
2020-03-04 8:15 ` Jiri Pirko
2020-03-03 19:44 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303114624.GG2178@nanopsycho \
--to=jiri@resnulli.us \
--cc=aelior@marvell.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=idosch@mellanox.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=peppe.cavallaro@st.com \
--cc=saeedm@mellanox.com \
--cc=vishal@chelsio.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).