From: Jakub Kicinski <kuba@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
oss-drivers@netronome.com
Subject: Re: [PATCH 4/7] nfp: Use scnprintf() for avoiding potential buffer overflow
Date: Wed, 11 Mar 2020 14:44:16 -0700 [thread overview]
Message-ID: <20200311144416.624c979c@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <20200311083745.17328-5-tiwai@suse.de>
On Wed, 11 Mar 2020 09:37:42 +0100 Takashi Iwai wrote:
> @@ -680,7 +680,7 @@ static int enable_bars(struct nfp6000_pcie *nfp, u16 interface)
> bar->iomem = ioremap(nfp_bar_resource_start(bar),
> nfp_bar_resource_len(bar));
> if (bar->iomem) {
> - msg += snprintf(msg, end - msg,
> + msg += scnprintf(msg, end - msg,
> "0.%d: Explicit%d, ", 4 + i, i);
Thanks for the patches! One nit pick - please adjust the continuation
lines so it starts on the column after the opening bracket (other
patches have the same problem).
You can try running scripts/checkpatch --strict on your patches, it
should catch these.
next prev parent reply other threads:[~2020-03-11 21:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 8:37 [PATCH 0/7] net: Use scnprintf() for avoiding potential buffer overflow Takashi Iwai
2020-03-11 8:37 ` [PATCH 1/7] net: caif: " Takashi Iwai
2020-03-11 8:37 ` [PATCH 2/7] i40e: " Takashi Iwai
2020-03-16 20:32 ` [Intel-wired-lan] " Bowers, AndrewX
2020-03-11 8:37 ` [PATCH 3/7] mlx4: " Takashi Iwai
2020-03-11 8:37 ` [PATCH 4/7] nfp: " Takashi Iwai
2020-03-11 11:01 ` [oss-drivers] " Simon Horman
2020-03-11 21:44 ` Jakub Kicinski [this message]
2020-03-11 8:37 ` [PATCH 5/7] ionic: " Takashi Iwai
2020-03-11 11:01 ` [oss-drivers] " Simon Horman
2020-03-11 16:45 ` Shannon Nelson
2020-03-11 8:37 ` [PATCH 6/7] sfc: " Takashi Iwai
2020-03-12 9:53 ` Martin Habets
2020-03-12 11:38 ` Takashi Iwai
2020-03-11 8:37 ` [PATCH 7/7] netdevsim: " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311144416.624c979c@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).