From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@cs.helsinki.fi
Cc: netdev@vger.kernel.org, ycheng@google.com, ncardwell@google.com,
eric.dumazet@gmail.com, olivier.tilmans@nokia-bell-labs.com
Subject: Re: [RFC PATCH 00/28]: Accurate ECN for TCP
Date: Thu, 19 Mar 2020 21:38:32 -0700 (PDT) [thread overview]
Message-ID: <20200319.213832.2258629564733373153.davem@davemloft.net> (raw)
In-Reply-To: <alpine.DEB.2.20.2003192222320.5256@whs-18.cs.helsinki.fi>
From: "Ilpo Järvinen" <ilpo.jarvinen@cs.helsinki.fi>
Date: Thu, 19 Mar 2020 22:25:23 +0200 (EET)
> On Wed, 18 Mar 2020, David Miller wrote:
>
>> From: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
>> Date: Wed, 18 Mar 2020 11:43:04 +0200
>>
>> > Comments would be highly appreciated.
>>
>> Two coding style comments which you should audit your entire submission
>> for:
>>
>> 1) Please order local variables in reverse christmas tree ordering (longest
>> to shortest long)
>
> Does this apply also to the usual struct tcp_sock *tp = tcp_sk(sk); line
> or can it be put first if there are some dependencies on it?
Yes, please. Put the assignment into the code lines if necessary.
prev parent reply other threads:[~2020-03-20 4:38 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 9:43 [RFC PATCH 00/28]: Accurate ECN for TCP Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 01/28] tcp: add tp to prepare for AccECN code Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 02/28] tcp: fast path functions later Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 03/28] tcp: move tcp_in_ack_event later Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 04/28] tcp: create FLAG_TS_PROGRESS Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 05/28] tcp: extend TCP flags to allow AE bit/ACE field Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 06/28] tcp: reorganize SYN ECN code Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 07/28] tcp: rework {__,}tcp_ecn_check_ce() -> tcp_data_ecn_check() Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 08/28] tcp: helpers for ECN mode handling Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 09/28] gso: AccECN support Ilpo Järvinen
2020-03-19 3:44 ` Eric Dumazet
2020-03-19 22:36 ` Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 10/28] gro: prevent ACE field corruption & better AccECN handling Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 11/28] tcp: AccECN support to tcp_add_backlog Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 12/28] tcp: AccECN core Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 13/28] tcp: Pass flags to tcp_send_ack Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 14/28] tcp: AccECN negotiation Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 15/28] tcp: add AccECN rx byte counters Ilpo Järvinen
2020-03-19 3:36 ` Eric Dumazet
2020-03-18 9:43 ` [RFC PATCH 16/28] tcp: allow embedding leftover into option padding Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 17/28] tcp: AccECN needs to know delivered bytes Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 18/28] tcp: don't early return when sack doesn't fit Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 19/28] tcp: AccECN option Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 20/28] tcp: AccECN option send control Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 21/28] tcp: AccECN option beacon Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 22/28] tcp: AccECN option order bit & failure handling Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 23/28] tcp: AccECN option ceb/cep heuristic Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 24/28] tcp: try to fit AccECN option with SACK Ilpo Järvinen
2020-03-19 3:29 ` Eric Dumazet
2020-03-19 20:33 ` Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 25/28] tcp: try to avoid safer when ACKs are thinned Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 26/28] tcp: to prevent runaway AccECN cep/ACE deficit, limit GSO size Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 27/28] gro: flushing when CWR is set negatively affects AccECN Ilpo Järvinen
2020-03-18 9:43 ` [RFC PATCH 28/28] tcp: AccECN sysctl documentation Ilpo Järvinen
2020-03-19 23:02 ` Dave Taht
2020-03-20 22:40 ` Ilpo Järvinen
2020-03-20 23:22 ` Yuchung Cheng
2020-03-23 13:34 ` Ilpo Järvinen
2020-03-23 19:03 ` Yuchung Cheng
2020-03-24 12:50 ` Ilpo Järvinen
2020-03-24 17:05 ` Yuchung Cheng
2020-03-18 23:29 ` [RFC PATCH 00/28]: Accurate ECN for TCP David Miller
2020-03-19 20:25 ` Ilpo Järvinen
2020-03-20 4:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319.213832.2258629564733373153.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ilpo.jarvinen@cs.helsinki.fi \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=olivier.tilmans@nokia-bell-labs.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).