From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Eran Ben Elisha <eranbe@mellanox.com>,
netdev@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
Michael Chan <michael.chan@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [PATCH net-next 2/2] devlink: Add auto dump flag to health reporter
Date: Thu, 26 Mar 2020 22:23:16 +0100 [thread overview]
Message-ID: <20200326212316.GI11304@nanopsycho.orion> (raw)
In-Reply-To: <20200326103913.150b8108@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Thu, Mar 26, 2020 at 06:39:13PM CET, kuba@kernel.org wrote:
>On Thu, 26 Mar 2020 11:22:44 +0100 Jiri Pirko wrote:
>> >> >>> @@ -4983,6 +4985,10 @@ devlink_nl_health_reporter_fill(struct sk_buff *msg,
>> >> >>> nla_put_u64_64bit(msg, DEVLINK_ATTR_HEALTH_REPORTER_DUMP_TS_NS,
>> >> >>> reporter->dump_real_ts, DEVLINK_ATTR_PAD))
>> >> >>> goto reporter_nest_cancel;
>> >> >>> + if (reporter->ops->dump &&
>> >> >>> + nla_put_u8(msg, DEVLINK_ATTR_HEALTH_REPORTER_AUTO_DUMP,
>> >> >>> + reporter->auto_dump))
>> >> >>> + goto reporter_nest_cancel;
>> >> >>
>> >> >> Since you're making it a u8 - does it make sense to indicate to user
>> >> >
>> >> > Please don't be mistaken. u8 carries a bool here.
>> >
>> >Are you okay with limiting the value in the policy?
>>
>> Well, not-0 means true. Do you think it is wise to limit to 0/1?
>
>Just future proofing, in general seems wise to always constrain the
>input as much as possible. But in this case we already have similar
>attrs in the dump which don't have the constraint, and we will probably
>want consistency, so maybe we're unlikely to use other values.
Agreed.
>
>In particular I was wondering if auto-dump value can be extended to
>mean the number of dumps we want to collect, the current behavior I
>think matches collecting just one. But obviously this can be solved
>with a new attr when needed..
prev parent reply other threads:[~2020-03-26 21:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 13:26 [PATCH net-next 0/2] Devlink health auto attributes refactor Eran Ben Elisha
2020-03-25 13:26 ` [PATCH net-next 1/2] devlink: Implicitly set auto recover flag when registering health reporter Eran Ben Elisha
2020-03-25 18:33 ` Jakub Kicinski
2020-03-25 13:26 ` [PATCH net-next 2/2] devlink: Add auto dump flag to " Eran Ben Elisha
2020-03-25 18:45 ` Jakub Kicinski
2020-03-25 19:08 ` Jiri Pirko
2020-03-25 19:38 ` Eran Ben Elisha
2020-03-26 0:01 ` Jakub Kicinski
2020-03-26 9:06 ` Eran Ben Elisha
2020-03-26 10:22 ` Jiri Pirko
2020-03-26 17:39 ` Jakub Kicinski
2020-03-26 21:23 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326212316.GI11304@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).