From: Jakub Kicinski <kuba@kernel.org>
To: tanhuazhong <tanhuazhong@huawei.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <salil.mehta@huawei.com>,
<yisen.zhuang@huawei.com>, <linuxarm@huawei.com>
Subject: Re: [PATCH net-next 3/5] net: hns3: provide .get_cmdq_stat interface for the client
Date: Sun, 10 May 2020 19:47:05 -0700 [thread overview]
Message-ID: <20200510194705.0082267b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1b76cac7-b1cc-cbab-cef4-cefeaa25ac62@huawei.com>
On Mon, 11 May 2020 08:13:06 +0800 tanhuazhong wrote:
> On 2020/5/10 4:48, Jakub Kicinski wrote:
> > On Sat, 9 May 2020 17:27:39 +0800 Huazhong Tan wrote:
> >> diff --git a/drivers/net/ethernet/hisilicon/hns3/hnae3.h b/drivers/net/ethernet/hisilicon/hns3/hnae3.h
> >> index 5602bf2..7506cab 100644
> >> --- a/drivers/net/ethernet/hisilicon/hns3/hnae3.h
> >> +++ b/drivers/net/ethernet/hisilicon/hns3/hnae3.h
> >> @@ -552,6 +552,7 @@ struct hnae3_ae_ops {
> >> int (*set_vf_mac)(struct hnae3_handle *handle, int vf, u8 *p);
> >> int (*get_module_eeprom)(struct hnae3_handle *handle, u32 offset,
> >> u32 len, u8 *data);
> >> + bool (*get_cmdq_stat)(struct hnae3_handle *handle);
> >> };
> >
> > I don't see anything in this series using this new interface, why is it
> > added now?
>
> This interface is needed by the roce client, whose patch will be
> upstreamed to the rdma tree, it is other branch. So we provide this
> interface previously, then the rdma guy will upstream their patch later,
> maybe linux-5.8-rc*.
Understood. Please make sure to include this kind of information in the
cover letter in the future.
next prev parent reply other threads:[~2020-05-11 2:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 9:27 [PATCH net-next 0/5] net: hns3: misc updates for -next Huazhong Tan
2020-05-09 9:27 ` [PATCH net-next 1/5] net: hns3: remove a redundant register macro definition Huazhong Tan
2020-05-09 9:27 ` [PATCH net-next 2/5] net: hns3: modify two uncorrect macro names Huazhong Tan
2020-05-09 9:27 ` [PATCH net-next 3/5] net: hns3: provide .get_cmdq_stat interface for the client Huazhong Tan
2020-05-09 20:48 ` Jakub Kicinski
2020-05-11 0:13 ` tanhuazhong
2020-05-11 2:47 ` Jakub Kicinski [this message]
2020-05-09 9:27 ` [PATCH net-next 4/5] net: hns3: optimized the judgment of the input parameters of dump ncl config Huazhong Tan
2020-05-09 9:27 ` [PATCH net-next 5/5] net: hns3: disable auto-negotiation off with 1000M setting in ethtool Huazhong Tan
2020-05-11 2:47 ` [PATCH net-next 0/5] net: hns3: misc updates for -next Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200510194705.0082267b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=tanhuazhong@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).