netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Florian Westphal <fw@strlen.de>,
	netdev@vger.kernel.org, matthieu.baerts@tessares.net,
	mathew.j.martineau@linux.intel.com
Subject: Re: [PATCH net-next] mptcp: adjust tcp rcvspace after moving skbs from ssk to sk queue
Date: Fri, 22 May 2020 17:10:10 +0200	[thread overview]
Message-ID: <20200522151010.GC26949@breakpoint.cc> (raw)
In-Reply-To: <c0f4e88f0a1b5449b341f2f7747a4aa7994089e7.camel@redhat.com>

Paolo Abeni <pabeni@redhat.com> wrote:
> It looks like this way ssk rcvbuf will grow up to tcp_rmem[2] even if
> there is no user-space reader - assuming the link is fast enough.
> 
> Don't we need to somehow cap that? e.g. moving mptcp rcvbuf update in
> mptcp_revmsg()?

From irc discussion it looks like you already have a patch for that.

I marked this patch as "Changes Requested" and do not plan to resend
it for the time being.

      reply	other threads:[~2020-05-22 15:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22 12:43 [PATCH net-next] mptcp: adjust tcp rcvspace after moving skbs from ssk to sk queue Florian Westphal
2020-05-22 14:22 ` Paolo Abeni
2020-05-22 15:10   ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200522151010.GC26949@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=matthieu.baerts@tessares.net \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).