From: David Miller <davem@davemloft.net>
To: gnault@redhat.com
Cc: kuba@kernel.org, netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@mellanox.com,
benjamin.lahaise@netronome.com, tom@herbertland.com,
pieter.jansenvanvuuren@netronome.com, pablo@netfilter.org,
liels@mellanox.com, ronye@mellanox.com
Subject: Re: [PATCH net-next v2 0/2] flow_dissector, cls_flower: Add support for multiple MPLS Label Stack Entries
Date: Mon, 25 May 2020 17:49:51 -0700 (PDT) [thread overview]
Message-ID: <20200525.174951.2144256991021641644.davem@davemloft.net> (raw)
In-Reply-To: <20200525.173818.1886112260004012915.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Mon, 25 May 2020 17:38:18 -0700 (PDT)
> Series applied, thanks.
Reverted, this doesn't even build with the one of the most popular drivers
in the tree, mlx5.
drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_mplsoudp.c: In function ‘parse_tunnel’:
drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_mplsoudp.c:105:52: error: ‘struct flow_dissector_key_mpls’ has no member named ‘mpls_label’
105 | outer_first_mpls_over_udp.mpls_label, match.mask->mpls_label);
| ^~
./include/linux/mlx5/device.h:74:11: note: in definition of macro ‘MLX5_SET’
74 | u32 _v = v; \
| ^
drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_mplsoudp.c:107:51: error: ‘struct flow_dissector_key_mpls’ has no member named ‘mpls_label’
107 | outer_first_mpls_over_udp.mpls_label, match.key->mpls_label);
| ^~
./include/linux/mlx5/device.h:74:11: note: in definition of macro ‘MLX5_SET’
74 | u32 _v = v; \
| ^
next prev parent reply other threads:[~2020-05-26 0:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 17:47 [PATCH net-next v2 0/2] flow_dissector, cls_flower: Add support for multiple MPLS Label Stack Entries Guillaume Nault
2020-05-21 17:47 ` [PATCH net-next v2 1/2] flow_dissector: Parse " Guillaume Nault
2020-05-23 9:55 ` Guillaume Nault
2020-05-21 17:47 ` [PATCH net-next v2 2/2] cls_flower: Support filtering on " Guillaume Nault
2020-05-23 16:35 ` [PATCH net-next v2 0/2] flow_dissector, cls_flower: Add support for " Guillaume Nault
2020-05-26 0:38 ` David Miller
2020-05-26 0:49 ` David Miller [this message]
2020-05-26 7:54 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525.174951.2144256991021641644.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benjamin.lahaise@netronome.com \
--cc=gnault@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=liels@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=pieter.jansenvanvuuren@netronome.com \
--cc=ronye@mellanox.com \
--cc=tom@herbertland.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).