From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Michael Chan <michael.chan@broadcom.com>,
Vasundhara Volam <vasundhara-v.volam@broadcom.com>,
David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>, Jiri Pirko <jiri@mellanox.com>
Subject: Re: [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter.
Date: Mon, 1 Jun 2020 14:44:36 -0700 [thread overview]
Message-ID: <20200601144436.75bab03f@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20200601063918.GD2282@nanopsycho>
On Mon, 1 Jun 2020 08:39:18 +0200 Jiri Pirko wrote:
> > If the permanent (NVRAM) parameter is true, all loaded new drivers
> > will indicate support for this feature and set the runtime value to
> > true by default. The runtime value would not be true if any loaded
> > driver is too old or has set the runtime value to false.
>
> This is a bit odd. It is a configuration, not an indication. When you
> want to indicate what you support something, I think it should be done
> in a different place. I think that "devlink dev info" is the place to
> put it, I think that we need "capabilities" there.
Could you explain the need for "capabilities" under dev info?
I don't like catch-all mechanisms in principle. Better if capabilities
are expressed by the API dedicated to configuration of a given feature.
In this particular example the ability to do live reset is clearly
expressed by the presence of the parameter (as implemented by this set).
next prev parent reply other threads:[~2020-06-01 21:44 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-23 6:08 [PATCH v2 net-next 0/4] bnxt_en: Add new "allow_fw_live_reset" generic devlink parameter Vasundhara Volam
2020-05-23 6:08 ` [PATCH v2 net-next 1/4] devlink: Add new "allow_fw_live_reset" generic device parameter Vasundhara Volam
2020-05-24 4:53 ` Jiri Pirko
2020-05-24 6:29 ` Vasundhara Volam
2020-05-25 17:26 ` Jiri Pirko
2020-05-26 4:28 ` Vasundhara Volam
2020-05-26 4:47 ` Jiri Pirko
2020-05-26 6:42 ` Vasundhara Volam
2020-05-26 13:40 ` Jiri Pirko
2020-05-26 14:23 ` Vasundhara Volam
2020-05-27 3:37 ` Vasundhara Volam
2020-05-27 20:14 ` Jakub Kicinski
2020-05-27 20:57 ` Michael Chan
2020-05-27 21:16 ` Jakub Kicinski
2020-05-28 1:50 ` Vasundhara Volam
2020-05-28 19:05 ` Jakub Kicinski
2020-05-29 14:29 ` Vasundhara Volam
2020-06-01 6:40 ` Jiri Pirko
2020-06-01 6:39 ` Jiri Pirko
2020-06-01 8:50 ` Vasundhara Volam
2020-06-01 9:49 ` Jiri Pirko
2020-06-01 9:57 ` Vasundhara Volam
2020-06-01 10:05 ` Jiri Pirko
2020-06-01 21:44 ` Jakub Kicinski [this message]
2020-06-02 6:28 ` Jiri Pirko
2020-06-01 7:18 ` Jiri Pirko
2020-06-01 8:53 ` Vasundhara Volam
2020-06-01 9:50 ` Jiri Pirko
2020-06-01 9:59 ` Vasundhara Volam
2020-06-01 10:05 ` Jiri Pirko
2020-05-23 6:08 ` [PATCH v2 net-next 2/4] bnxt_en: Update firmware spec. to 1.10.1.40 Vasundhara Volam
2020-05-23 6:08 ` [PATCH v2 net-next 3/4] bnxt_en: Use allow_fw_live_reset generic devlink parameter Vasundhara Volam
2020-05-23 6:08 ` [PATCH v2 net-next 4/4] bnxt_en: Check if fw_live_reset is allowed before doing ETHTOOL_RESET Vasundhara Volam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601144436.75bab03f@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=jiri@resnulli.us \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vasundhara-v.volam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).