From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22FBCC433E1 for ; Wed, 1 Jul 2020 15:58:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1680207F5 for ; Wed, 1 Jul 2020 15:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593619093; bh=V1iDW3HLHhSqBPcQehF0Rgg3mQVIlF7VSD1AxxlZohs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=s3Mbcgg2dtoG4igIxixOxafJLT4jfBltRd38s5uuRRrsEiBLPrzjIRlSOqCwvhubF R0vC3Y8HbbRD/cPZ8l/t8oTL4oAGtkXiD8NjMeKbGm2Rto33QnDxjCDwz+mLQJZM1V PsxLCrANLr+R1mYG+5dFmcZOEc3csJIkcYdTMyas= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732168AbgGAP6J (ORCPT ); Wed, 1 Jul 2020 11:58:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:38370 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729308AbgGAP6J (ORCPT ); Wed, 1 Jul 2020 11:58:09 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B614207BB; Wed, 1 Jul 2020 15:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593619088; bh=V1iDW3HLHhSqBPcQehF0Rgg3mQVIlF7VSD1AxxlZohs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zP1k9VygO6HMuMhSsK3Ri5ecwyhKTBVem6tv7+iZlkO2LfWUPUV8kB5w+xwQCC/yb NPWSYrq7lNKdPGH1kSf357yagD/OZvsRD5rkLejuyYhXie53xsFQIUIwXq5sqVL24C QWNqJuqt4nKNy53k2fBP6LoHQEIv1WZqAY2xP7+A= Date: Wed, 1 Jul 2020 08:58:05 -0700 From: Jakub Kicinski To: Vaibhav Gupta Cc: Bjorn Helgaas , Bjorn Helgaas , bjorn@helgaas.com, Vaibhav Gupta , "David S. Miller" , David Dillow , Ion Badulescu , Netanel Belgazal , Arthur Kiyanovski , Guy Tzalik , Saeed Bishara , Zorik Machulsky , Derek Chickles , Satanand Burla , Felix Manlunas , Denis Kirjanov , Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur , Tariq Toukan , Jon Mason , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org Subject: Re: [PATCH v1 04/11] ena_netdev: use generic power management Message-ID: <20200701085805.4dac84fb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200701125938.639447-5-vaibhavgupta40@gmail.com> References: <20200701125938.639447-1-vaibhavgupta40@gmail.com> <20200701125938.639447-5-vaibhavgupta40@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 1 Jul 2020 18:29:31 +0530 Vaibhav Gupta wrote: > With legacy PM, drivers themselves were responsible for managing the > device's power states and takes care of register states. >=20 > After upgrading to the generic structure, PCI core will take care of > required tasks and drivers should do only device-specific operations. >=20 > Compile-tested only. >=20 > Signed-off-by: Vaibhav Gupta This one produces a warning on a W=3D1 build: drivers/net/ethernet/amazon/ena/ena_netdev.c:4464:26: warning: =E2=80=98ena= _pm_ops=E2=80=99 defined but not used [-Wunused-const-variable=3D] 4464 | static SIMPLE_DEV_PM_OPS(ena_pm_ops, ena_suspend, ena_resume);