From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <snelson@pensando.io>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH v2 net-next 3/3] ionic: separate interrupt for Tx and Rx
Date: Thu, 30 Jul 2020 17:44:42 -0700 [thread overview]
Message-ID: <20200730174442.6bb9e652@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200731000058.37344-4-snelson@pensando.io>
On Thu, 30 Jul 2020 17:00:58 -0700 Shannon Nelson wrote:
> + max_cnt = lif->ionic->ntxqs_per_lif;
> + if (ch->combined_count) {
> + if (!test_bit(IONIC_LIF_F_SPLIT_INTR, lif->state) &&
> + (ch->combined_count == lif->nxqs)) {
> + netdev_info(netdev, "No change a\n");
> + return 0;
> + }
> +
> + netdev_info(netdev, "Changing queue count from %d to %d\n",
> + lif->nxqs, ch->combined_count);
> + } else {
> + max_cnt /= 2;
> + if (test_bit(IONIC_LIF_F_SPLIT_INTR, lif->state) &&
> + (ch->rx_count == lif->nxqs)) {
> + netdev_info(netdev, "No change b\n");
> + return 0;
> + }
> +
> + netdev_info(netdev, "Changing queue count from %d to %d\n",
> + lif->nxqs, ch->rx_count);
> + }
A little verbose there with the printin' but overall looks reasonable:
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
prev parent reply other threads:[~2020-07-31 0:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 0:00 [PATCH v2 net-next 0/3] ionic txrx updates Shannon Nelson
2020-07-31 0:00 ` [PATCH v2 net-next 1/3] ionic: use fewer firmware doorbells on rx fill Shannon Nelson
2020-07-31 0:00 ` [PATCH v2 net-next 2/3] ionic: tx separate servicing Shannon Nelson
2020-07-31 0:00 ` [PATCH v2 net-next 3/3] ionic: separate interrupt for Tx and Rx Shannon Nelson
2020-07-31 0:44 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730174442.6bb9e652@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).