From: David Miller <davem@davemloft.net>
To: bruno.thomsen@gmail.com
Cc: netdev@vger.kernel.org, andrew@lunn.ch, festevam@gmail.com,
f.fainelli@gmail.com, linux@armlinux.org.uk,
hkallweit1@gmail.com, laa@kamstrup.com, bth@kamstrup.com
Subject: Re: [PATCH v2 0/4 net-next] Improve MDIO Ethernet PHY reset
Date: Mon, 03 Aug 2020 15:01:43 -0700 (PDT) [thread overview]
Message-ID: <20200803.150143.1814094529162821629.davem@davemloft.net> (raw)
In-Reply-To: <20200730195749.4922-1-bruno.thomsen@gmail.com>
From: Bruno Thomsen <bruno.thomsen@gmail.com>
Date: Thu, 30 Jul 2020 21:57:45 +0200
> This patch series is a result of trying to upstream a new device
> tree for a TQMa7D based board[1][2]. Initial this DTS used some
> deprecated PHY reset properties on the FEC device; NXP Ethernet
> MAC also known as Freescale Fast Ethernet Controller.
>
> When switching from FEC properties[3]:
> "phy-reset-gpios"
> "phy-reset-duration"
> "phy-reset-post-delay"
>
> To MDIO PHY properties[4]:
> "reset-gpios"
> "reset-assert-us"
> "reset-deassert-us"
>
> The result was that no Ethernet PHY device was detected on boot.
>
> This issue could be worked around by disabling PHY type ID auto-
> detection by using "ethernet-phy-id0022.1560" as compatible
> string and not "ethernet-phy-ieee802.3-c22".
>
> Upstreaming a DTS with this workaround was not accepted, so I
> digged into the MDIO reset flow and found that it had a few
> missing parts compared to the deprecated FEC reset function.
> After some more testing and logic analyzer traces it was
> revealed that the failed PHY communication was due to missing
> initial device reset.
...
Series applied, thank you.
prev parent reply other threads:[~2020-08-03 22:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 19:57 [PATCH v2 0/4 net-next] Improve MDIO Ethernet PHY reset Bruno Thomsen
2020-07-30 19:57 ` [PATCH v2 1/4 net-next] dt-bindings: net: mdio: add reset-post-delay-us property Bruno Thomsen
2020-08-02 16:46 ` Andrew Lunn
2020-08-02 20:16 ` Florian Fainelli
2020-07-30 19:57 ` [PATCH v2 2/4 net-next] net: mdiobus: use flexible sleeping for reset-delay-us Bruno Thomsen
2020-08-02 16:46 ` Andrew Lunn
2020-08-02 20:17 ` Florian Fainelli
2020-07-30 19:57 ` [PATCH v2 3/4 net-next] net: mdiobus: add reset-post-delay-us handling Bruno Thomsen
2020-08-02 16:47 ` Andrew Lunn
2020-08-02 20:18 ` Florian Fainelli
2020-07-30 19:57 ` [PATCH v2 4/4 net-next] net: mdio device: use flexible sleeping in reset function Bruno Thomsen
2020-08-02 16:48 ` Andrew Lunn
2020-08-02 20:19 ` Florian Fainelli
2020-08-03 22:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803.150143.1814094529162821629.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=bruno.thomsen@gmail.com \
--cc=bth@kamstrup.com \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=laa@kamstrup.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).