netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com,
	stephen@networkplumber.org, davem@davemloft.net,
	jiri@mellanox.com, kuba@kernel.org, michael.chan@broadcom.com
Subject: Re: [PATCH v3 iproute2-next] devlink: Add board.serial_number to info subcommand.
Date: Mon, 3 Aug 2020 13:22:03 +0200	[thread overview]
Message-ID: <20200803112203.GA2290@nanopsycho> (raw)
In-Reply-To: <20200731104643.35726-1-vasundhara-v.volam@broadcom.com>

Fri, Jul 31, 2020 at 12:46:43PM CEST, vasundhara-v.volam@broadcom.com wrote:
>Add support for reading board serial_number to devlink info
>subcommand. Example:
>
>$ devlink dev info pci/0000:af:00.0 -jp
>{
>    "info": {
>        "pci/0000:af:00.0": {
>            "driver": "bnxt_en",
>            "serial_number": "00-10-18-FF-FE-AD-1A-00",
>            "board.serial_number": "433551F+172300000",
>            "versions": {
>                "fixed": {
>                    "board.id": "7339763 Rev 0.",
>                    "asic.id": "16D7",
>                    "asic.rev": "1"
>                },
>                "running": {
>                    "fw": "216.1.216.0",
>                    "fw.psid": "0.0.0",
>                    "fw.mgmt": "216.1.192.0",
>                    "fw.mgmt.api": "1.10.1",
>                    "fw.ncsi": "0.0.0.0",
>                    "fw.roce": "216.1.16.0"
>                }
>            }
>        }
>    }
>}
>
>Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>

Looks fine.

Reviewed-by: Jiri Pirko <jiri@mellanox.com>

  reply	other threads:[~2020-08-03 11:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31 10:46 [PATCH v3 iproute2-next] devlink: Add board.serial_number to info subcommand Vasundhara Volam
2020-08-03 11:22 ` Jiri Pirko [this message]
2020-08-03 15:37 ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200803112203.GA2290@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=jiri@mellanox.com \
    --cc=kuba@kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=vasundhara-v.volam@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).