From: David Miller <davem@davemloft.net>
To: liuhangbin@gmail.com
Cc: gnault@redhat.com, netdev@vger.kernel.org, pmachata@gmail.com,
roopa@cumulusnetworks.com, dsahern@kernel.org, akaris@redhat.com
Subject: Re: [PATCH net] Revert "vxlan: fix tos value before xmit"
Date: Tue, 11 Aug 2020 17:02:23 -0700 (PDT) [thread overview]
Message-ID: <20200811.170223.1397578654908672695.davem@davemloft.net> (raw)
In-Reply-To: <20200806025241.GO2531@dhcp-12-153.nay.redhat.com>
From: Hangbin Liu <liuhangbin@gmail.com>
Date: Thu, 6 Aug 2020 10:52:41 +0800
> The rough steps are setting vxlan tunnel on OVS. set inner packet tos to
> 1011 1010 (0xba) and outer vxlan to 1111 1100(0xfc). The outer packet's tos
> should be 0xfe at latest as it inherit the inner ECN bit. But with RT_TOS(tos)
> We actually got tos 0x1e as the first 3 bits are omitted.
>
> Now here is detailed testing steps:
This explains why we need to revert the RT_TOS() change.
I'm asking what testing you did on the original change that added
RT_TOS(), which we reverted, and which didn't fix anything.
I want to know how we got into this situation in the first place,
adding a change that only added negative effects.
Thank you.
next prev parent reply other threads:[~2020-08-12 0:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 2:41 [PATCH net] Revert "vxlan: fix tos value before xmit" Hangbin Liu
2020-08-05 8:44 ` Guillaume Nault
2020-08-05 10:18 ` Hangbin Liu
2020-08-05 19:11 ` David Miller
2020-08-06 2:52 ` Hangbin Liu
2020-08-12 0:02 ` David Miller [this message]
2020-08-12 2:28 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811.170223.1397578654908672695.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akaris@redhat.com \
--cc=dsahern@kernel.org \
--cc=gnault@redhat.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pmachata@gmail.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).